Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add maxCommitDelay support #1992

Merged

Conversation

nginsberg-google
Copy link
Contributor

@nginsberg-google nginsberg-google commented Feb 8, 2024

maxCommitDelays allows the user to specify the maximum delay a commit request is willing to incur in order to improve throughput. This PR adds support for the feature in the commit API.

@nginsberg-google nginsberg-google requested review from a team as code owners February 8, 2024 01:06
Copy link

conventional-commit-lint-gcf bot commented Feb 8, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Feb 8, 2024
@nginsberg-google nginsberg-google changed the title feat(spanner): Add support for maxCommitDelays in commit. feat(spanner): add maxCommitDelay support Feb 8, 2024
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@surbhigarg92 surbhigarg92 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9f84408 into googleapis:main Feb 8, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants