Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for Directed Reads #1966

Merged
merged 9 commits into from
Jan 8, 2024
Merged

feat: Support for Directed Reads #1966

merged 9 commits into from
Jan 8, 2024

Conversation

surbhigarg92
Copy link
Contributor

No description provided.

@surbhigarg92 surbhigarg92 requested review from a team as code owners December 8, 2023 06:30
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 8, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Dec 8, 2023
asthamohta
asthamohta approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harshachinta
harshachinta reviewed Jan 7, 2024
View reviewed changes
src/transaction.ts Outdated Show resolved Hide resolved
harshachinta
harshachinta reviewed Jan 7, 2024
View reviewed changes
src/transaction.ts Outdated Show resolved Hide resolved
harshachinta
harshachinta reviewed Jan 7, 2024
View reviewed changes
src/transaction.ts Outdated Show resolved Hide resolved
harshachinta
harshachinta reviewed Jan 7, 2024
View reviewed changes
test/database.ts Outdated Show resolved Hide resolved
harshachinta
harshachinta reviewed Jan 7, 2024
View reviewed changes
test/transaction.ts Outdated Show resolved Hide resolved
harshachinta
harshachinta reviewed Jan 7, 2024
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few minor comments.

@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
harshachinta
harshachinta reviewed Jan 8, 2024
View reviewed changes
src/transaction.ts Outdated Show resolved Hide resolved
@surbhigarg92 surbhigarg92 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
harshachinta
harshachinta approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c0a4363 into googleapis:main Jan 8, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 8, 2024
@release-please release-please bot mentioned this pull request Jan 8, 2024
Merged
@surbhigarg92 surbhigarg92 deleted the directed_reads_surbhi branch January 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surbhigarg92 @asthamohta @harshachinta @yoshi-kokoro