feat(default_retention_period): Changes to backup.create API to suppo… #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt the default retention period feature With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of create backup then the backup will be retained for the duration of maximum retention period. In this commit, expireTime is made optional in CreateBackupOptions and backup.create API is fixed to handle the null value in the CreateBackupOptions.
product-auto-label
bot
added
size: s
|
@surbhigarg92 Could you please review this diff? Also, please add the "do not merge" label since the backend changes are not merged. |
surbhigarg92
added
the
do not merge
surbhigarg92
approved these changes
Jul 5, 2023
|
closing this PR as it no longer required with admin autogeneration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt the default retention period feature
With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of create backup then the backup will be retained for the duration of maximum retention period.
In this commit, expireTime is made optional in CreateBackupOptions and backup.create API is fixed to handle the null value in the CreateBackupOptions.