Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bit reverse sequence #1846

Merged
merged 27 commits into from
Aug 4, 2023
Merged

feat: Bit reverse sequence #1846

merged 27 commits into from
Aug 4, 2023

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners May 10, 2023 09:42
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 10, 2023
@snippet-bot
Copy link

snippet-bot bot commented May 10, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label May 10, 2023
surbhigarg92
surbhigarg92 reviewed May 12, 2023
View reviewed changes
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
rajatbhatta
rajatbhatta approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a few sample-metadata suggestions.

samples/pg-sequence-alter.js Outdated Show resolved Hide resolved
samples/pg-sequence-create.js Outdated Show resolved Hide resolved
samples/pg-sequence-drop.js Outdated Show resolved Hide resolved
samples/sequence-create.js Outdated Show resolved Hide resolved
samples/sequence-drop.js Outdated Show resolved Hide resolved
samples/sequence-alter.js Outdated Show resolved Hide resolved
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 4, 2023
@asthamohta asthamohta merged commit 4154c02 into googleapis:main Aug 4, 2023
13 checks passed
@release-please release-please bot mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asthamohta @surbhigarg92 @rajatbhatta