Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing table_catalog from schema information #1595

Merged
merged 16 commits into from
Mar 29, 2022
Merged

fix: removing table_catalog from schema information #1595

merged 16 commits into from
Mar 29, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

asthamohta and others added 14 commits March 24, 2022 14:53
@asthamohta
feat: Database Dialect support
b359c67
@asthamohta
feat: Adding support for PG Numeric
9c10094
@asthamohta
fix: fixing bug in PG Numeric Support
275e20e
@asthamohta
feat: adding samples for PG Numeric
288e125
@asthamohta
feat: Adding samples for PG
49024ce
@asthamohta
feat: changes in samples as per comments,renaming tags, merging numer…
116287c 
…ic samples
@asthamohta
comment changes
ad7c0f5
@asthamohta
fix: allowing number in pgNumeric
8f99951
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
2466f3f 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@asthamohta @olavloite
Update samples/README.md
805ac10 
Co-authored-by: Knut Olav Løite <[email protected]>
@asthamohta @olavloite
Update samples/pg-database-create.js
467382a 
Co-authored-by: Knut Olav Løite <[email protected]>
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
8db1de5 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@asthamohta
Merge branch 'googleapis:main' into postgresql_dialect
261a755
@asthamohta
fix: removing table_catalog
7eb8006
@asthamohta asthamohta requested review from a team as code owners March 28, 2022 06:56
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Mar 28, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@asthamohta asthamohta linked an issue Mar 29, 2022 that may be closed by this pull request
Spanner postgreSQL: should query the information schema metadata in a Spanner PostgreSQL database failed #1594
Closed
vi3k6i5
vi3k6i5 approved these changes Mar 29, 2022
View reviewed changes
Copy link

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@asthamohta asthamohta merged commit 8bcbd95 into googleapis:main Mar 29, 2022
@release-please release-please bot mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vi3k6i5 vi3k6i5 vi3k6i5 approved these changes

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner postgreSQL: should query the information schema metadata in a Spanner PostgreSQL database failed
3 participants
@asthamohta @olavloite @vi3k6i5