-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spanner copy backup #1530
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
70769a3
to
069c74c
Compare
44b9e69
to
68b8a27
Compare
568d62b
to
463f48c
Compare
463f48c
to
5332b83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
453850a
to
2e489e3
Compare
f953fdc
to
1aa86a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except small nit change.
@@ -15,6 +15,7 @@ and automatic, synchronous replication for high availability. | |||
* [Before you begin](#before-you-begin) | |||
* [Samples](#samples) | |||
* [Backups-cancel](#backups-cancel) | |||
* [Copies a source backup](#copies-a-source-backup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rest of the links are "-" separated. Maybe change to [Copy-source-backup]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is because this is in the new format of test. As you can see on line 34-36, this is acceptable
The following functionalities are added in this PR: