Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spanner copy backup #1530

Merged
merged 9 commits into from
Mar 24, 2022
Merged

Conversation

asthamohta
Copy link
Contributor

The following functionalities are added in this PR:

  1. Support for copyBackup in the Node client
  2. Samples for copyBackup
  3. Support for maxExpireTime and referencingBackup
  4. Updating update backup sample to reflect how to use maxExpireTime

@asthamohta asthamohta requested review from a team as code owners January 4, 2022 09:41
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 4, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jan 4, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

samples/backups-copy.js Outdated Show resolved Hide resolved
samples/backups-copy.js Outdated Show resolved Hide resolved
samples/backups-copy.js Outdated Show resolved Hide resolved
samples/backups-copy.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
src/instance.ts Outdated Show resolved Hide resolved
Copy link

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta asthamohta changed the title Spanner copy backup feat: Spanner copy backup Mar 22, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
Copy link

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except small nit change.

@@ -15,6 +15,7 @@ and automatic, synchronous replication for high availability.
* [Before you begin](#before-you-begin)
* [Samples](#samples)
* [Backups-cancel](#backups-cancel)
* [Copies a source backup](#copies-a-source-backup)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rest of the links are "-" separated. Maybe change to [Copy-source-backup]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is because this is in the new format of test. As you can see on line 34-36, this is acceptable

@asthamohta asthamohta merged commit cefb1b4 into googleapis:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants