This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Mar 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 91.07% 90.97% -0.11%
==========================================
Files 3 5 +2
Lines 1120 2237 +1117
Branches 52 103 +51
==========================================
+ Hits 1020 2035 +1015
- Misses 99 200 +101
- Partials 1 2 +1
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Mar 24, 2020
feywind
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can't remember where we ended up on that discussion about leaving the beta vs v1 APIs in place. I guess my main comment is to make sure we're being consistent there.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 25, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.8.0](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/compare/v1.7.0...v1.8.0) (2020-03-25) ### Features * add the v1 API surface ([#141](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/issues/141)) ([bb1bd33](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/commit/bb1bd33c1f51d37ca8db15ce7579259560250530)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 18, 2022
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2022-05-18) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#374) * rename parent to project in SearchRelatedAccountGroupMembershipsRequest (#370) * remove key management API (#366) * Remove RecaptchaEnterpriseServiceV1Beta1Client. * The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. * upgrade engines field to >=8.10.0 (#2) ### Features * add crud support for keys ([#84](#84)) ([adfc3f9](adfc3f9)) * add GetMetrics and MigrateKey methods to reCAPTCHA enterprise API ([#318](#318)) ([55b1adc](55b1adc)) * add new reCAPTCHA Enterprise fraud annotations ([#334](#334)) ([24fdff1](24fdff1)) * add plural and singular resource descriptor ([#78](#78)) ([a67ffa7](a67ffa7)) * add reCAPTCHA Enterprise account defender API methods ([#328](#328)) ([2099c50](2099c50)) * Add support for Password Check through the private_password_leak_verification field in the reCAPTCHA Assessment ([#376](#376)) ([7c1583c](7c1583c)) * add the v1 API surface ([#141](#141)) ([bb1bd33](bb1bd33)) * deferred client initialization ([#128](#128)) ([3de999e](3de999e)) * drop node8 support, support for async iterators ([#145](#145)) ([cc4cc51](cc4cc51)) * export protos in src/index.ts ([ffd77ca](ffd77ca)) * introduces style enumeration ([#234](#234)) ([35f1bb6](35f1bb6)) * load protos from JSON, grpc-fallback support ([7a4b2a6](7a4b2a6)) * move to typescript code generation ([#87](#87)) ([11051db](11051db)) * support apiEndpoint override in client constructor ([#30](#30)) ([1192afd](1192afd)) * turns on self-signed JWT feature flag ([#311](#311)) ([c12da34](c12da34)) * update scopes and classifications ([#60](#60)) ([b216630](b216630)) ### Bug Fixes * allow calls with no request, add JSON proto ([ab643f8](ab643f8)) * **browser:** check for fetch on window ([#226](#226)) ([8eb79dd](8eb79dd)) * **build:** switch primary branch to main ([#315](#315)) ([2fc99ad](2fc99ad)) * DEADLINE_EXCEEDED retry code is idempotent ([#10](#10)) ([746151c](746151c)) * **deps:** bump google-gax to 1.7.5 ([#68](#68)) ([0605bb8](0605bb8)) * **deps:** google-gax v2.17.0 with mTLS ([#294](#294)) ([45c12e5](45c12e5)) * **deps:** google-gax v2.17.1 ([#297](#297)) ([15640f1](15640f1)) * **deps:** google-gax v2.24.1 ([#309](#309)) ([de80090](de80090)) * **deps:** pin TypeScript below 3.7.0 ([0e96508](0e96508)) * **deps:** require google-gax v2.12.0 ([#270](#270)) ([ab16a25](ab16a25)) * **deps:** update dependency google-gax to v1 ([#17](#17)) ([0f9e159](0f9e159)) * do not modify options object, use defaultScopes ([#222](#222)) ([807b692](807b692)) * do not retry request on DEADLINE_EXCEEDED ([a6e9f4a](a6e9f4a)) * **docs:** bump the release level to beta ([#76](#76)) ([8a2e2c0](8a2e2c0)) * **docs:** link to reference docs section on googleapis.dev ([#35](#35)) ([14ada6b](14ada6b)) * **docs:** move to new client docs URL ([#32](#32)) ([6a95276](6a95276)) * **docs:** snippets are now replaced in jsdoc comments ([#74](#74)) ([b3c31fc](b3c31fc)) * enum, bytes, and Long types now accept strings ([394cfd8](394cfd8)) * export explicit version from protos.js ([#150](#150)) ([0bfb3c7](0bfb3c7)) * GoogleAdsError missing using generator version after 1.3.0 ([#279](#279)) ([6dc35a7](6dc35a7)) * include the correct version of node in a header ([#46](#46)) ([2cc8099](2cc8099)) * make request optional in all cases ([#290](#290)) ([e18a1d1](e18a1d1)) * pass x-goog-request-params header for streaming calls ([983411e](983411e)) * proper fallback option handling ([#180](#180)) ([52fe53d](52fe53d)) * proper routing headers ([4d1b1d3](4d1b1d3)) * regen protos and tests, formatting ([#169](#169)) ([731fe3b](731fe3b)) * remove eslint, update gax, fix generated protos, run the generator ([#155](#155)) ([21b09f5](21b09f5)) * remove key management API ([#366](#366)) ([44a5a4b](44a5a4b)) * rename parent to project in SearchRelatedAccountGroupMembershipsRequest ([#370](#370)) ([aad0883](aad0883)) * synth.py clean up for multiple version ([#172](#172)) ([ee1c250](ee1c250)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#299](#299)) ([6787e23](6787e23)) * use compatible version of google-gax ([dfb174a](dfb174a)) * use require() to load JSON protos ([#273](#273)) ([fdbc0fe](fdbc0fe)) ### Build System * update library to use Node 12 ([#374](#374)) ([4042ae2](4042ae2)) * upgrade engines field to >=8.10.0 ([#2](#2)) ([94d6a49](94d6a49)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced May 18, 2022
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2022-05-18) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#374) * rename parent to project in SearchRelatedAccountGroupMembershipsRequest (#370) * remove key management API (#366) * Remove RecaptchaEnterpriseServiceV1Beta1Client. * The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. * upgrade engines field to >=8.10.0 (#2) ### Features * add crud support for keys ([#84](googleapis/nodejs-recaptcha-enterprise#84)) ([adfc3f9](googleapis/nodejs-recaptcha-enterprise@adfc3f9)) * add GetMetrics and MigrateKey methods to reCAPTCHA enterprise API ([#318](googleapis/nodejs-recaptcha-enterprise#318)) ([55b1adc](googleapis/nodejs-recaptcha-enterprise@55b1adc)) * add new reCAPTCHA Enterprise fraud annotations ([#334](googleapis/nodejs-recaptcha-enterprise#334)) ([24fdff1](googleapis/nodejs-recaptcha-enterprise@24fdff1)) * add plural and singular resource descriptor ([#78](googleapis/nodejs-recaptcha-enterprise#78)) ([a67ffa7](googleapis/nodejs-recaptcha-enterprise@a67ffa7)) * add reCAPTCHA Enterprise account defender API methods ([#328](googleapis/nodejs-recaptcha-enterprise#328)) ([2099c50](googleapis/nodejs-recaptcha-enterprise@2099c50)) * Add support for Password Check through the private_password_leak_verification field in the reCAPTCHA Assessment ([#376](googleapis/nodejs-recaptcha-enterprise#376)) ([7c1583c](googleapis/nodejs-recaptcha-enterprise@7c1583c)) * add the v1 API surface ([#141](googleapis/nodejs-recaptcha-enterprise#141)) ([bb1bd33](googleapis/nodejs-recaptcha-enterprise@bb1bd33)) * deferred client initialization ([#128](googleapis/nodejs-recaptcha-enterprise#128)) ([3de999e](googleapis/nodejs-recaptcha-enterprise@3de999e)) * drop node8 support, support for async iterators ([#145](googleapis/nodejs-recaptcha-enterprise#145)) ([cc4cc51](googleapis/nodejs-recaptcha-enterprise@cc4cc51)) * export protos in src/index.ts ([ffd77ca](googleapis/nodejs-recaptcha-enterprise@ffd77ca)) * introduces style enumeration ([#234](googleapis/nodejs-recaptcha-enterprise#234)) ([35f1bb6](googleapis/nodejs-recaptcha-enterprise@35f1bb6)) * load protos from JSON, grpc-fallback support ([7a4b2a6](googleapis/nodejs-recaptcha-enterprise@7a4b2a6)) * move to typescript code generation ([#87](googleapis/nodejs-recaptcha-enterprise#87)) ([11051db](googleapis/nodejs-recaptcha-enterprise@11051db)) * support apiEndpoint override in client constructor ([#30](googleapis/nodejs-recaptcha-enterprise#30)) ([1192afd](googleapis/nodejs-recaptcha-enterprise@1192afd)) * turns on self-signed JWT feature flag ([#311](googleapis/nodejs-recaptcha-enterprise#311)) ([c12da34](googleapis/nodejs-recaptcha-enterprise@c12da34)) * update scopes and classifications ([#60](googleapis/nodejs-recaptcha-enterprise#60)) ([b216630](googleapis/nodejs-recaptcha-enterprise@b216630)) ### Bug Fixes * allow calls with no request, add JSON proto ([ab643f8](googleapis/nodejs-recaptcha-enterprise@ab643f8)) * **browser:** check for fetch on window ([#226](googleapis/nodejs-recaptcha-enterprise#226)) ([8eb79dd](googleapis/nodejs-recaptcha-enterprise@8eb79dd)) * **build:** switch primary branch to main ([#315](googleapis/nodejs-recaptcha-enterprise#315)) ([2fc99ad](googleapis/nodejs-recaptcha-enterprise@2fc99ad)) * DEADLINE_EXCEEDED retry code is idempotent ([#10](googleapis/nodejs-recaptcha-enterprise#10)) ([746151c](googleapis/nodejs-recaptcha-enterprise@746151c)) * **deps:** bump google-gax to 1.7.5 ([#68](googleapis/nodejs-recaptcha-enterprise#68)) ([0605bb8](googleapis/nodejs-recaptcha-enterprise@0605bb8)) * **deps:** google-gax v2.17.0 with mTLS ([#294](googleapis/nodejs-recaptcha-enterprise#294)) ([45c12e5](googleapis/nodejs-recaptcha-enterprise@45c12e5)) * **deps:** google-gax v2.17.1 ([#297](googleapis/nodejs-recaptcha-enterprise#297)) ([15640f1](googleapis/nodejs-recaptcha-enterprise@15640f1)) * **deps:** google-gax v2.24.1 ([#309](googleapis/nodejs-recaptcha-enterprise#309)) ([de80090](googleapis/nodejs-recaptcha-enterprise@de80090)) * **deps:** pin TypeScript below 3.7.0 ([0e96508](googleapis/nodejs-recaptcha-enterprise@0e96508)) * **deps:** require google-gax v2.12.0 ([#270](googleapis/nodejs-recaptcha-enterprise#270)) ([ab16a25](googleapis/nodejs-recaptcha-enterprise@ab16a25)) * **deps:** update dependency google-gax to v1 ([#17](googleapis/nodejs-recaptcha-enterprise#17)) ([0f9e159](googleapis/nodejs-recaptcha-enterprise@0f9e159)) * do not modify options object, use defaultScopes ([#222](googleapis/nodejs-recaptcha-enterprise#222)) ([807b692](googleapis/nodejs-recaptcha-enterprise@807b692)) * do not retry request on DEADLINE_EXCEEDED ([a6e9f4a](googleapis/nodejs-recaptcha-enterprise@a6e9f4a)) * **docs:** bump the release level to beta ([#76](googleapis/nodejs-recaptcha-enterprise#76)) ([8a2e2c0](googleapis/nodejs-recaptcha-enterprise@8a2e2c0)) * **docs:** link to reference docs section on googleapis.dev ([#35](googleapis/nodejs-recaptcha-enterprise#35)) ([14ada6b](googleapis/nodejs-recaptcha-enterprise@14ada6b)) * **docs:** move to new client docs URL ([#32](googleapis/nodejs-recaptcha-enterprise#32)) ([6a95276](googleapis/nodejs-recaptcha-enterprise@6a95276)) * **docs:** snippets are now replaced in jsdoc comments ([#74](googleapis/nodejs-recaptcha-enterprise#74)) ([b3c31fc](googleapis/nodejs-recaptcha-enterprise@b3c31fc)) * enum, bytes, and Long types now accept strings ([394cfd8](googleapis/nodejs-recaptcha-enterprise@394cfd8)) * export explicit version from protos.js ([#150](googleapis/nodejs-recaptcha-enterprise#150)) ([0bfb3c7](googleapis/nodejs-recaptcha-enterprise@0bfb3c7)) * GoogleAdsError missing using generator version after 1.3.0 ([#279](googleapis/nodejs-recaptcha-enterprise#279)) ([6dc35a7](googleapis/nodejs-recaptcha-enterprise@6dc35a7)) * include the correct version of node in a header ([#46](googleapis/nodejs-recaptcha-enterprise#46)) ([2cc8099](googleapis/nodejs-recaptcha-enterprise@2cc8099)) * make request optional in all cases ([#290](googleapis/nodejs-recaptcha-enterprise#290)) ([e18a1d1](googleapis/nodejs-recaptcha-enterprise@e18a1d1)) * pass x-goog-request-params header for streaming calls ([983411e](googleapis/nodejs-recaptcha-enterprise@983411e)) * proper fallback option handling ([#180](googleapis/nodejs-recaptcha-enterprise#180)) ([52fe53d](googleapis/nodejs-recaptcha-enterprise@52fe53d)) * proper routing headers ([4d1b1d3](googleapis/nodejs-recaptcha-enterprise@4d1b1d3)) * regen protos and tests, formatting ([#169](googleapis/nodejs-recaptcha-enterprise#169)) ([731fe3b](googleapis/nodejs-recaptcha-enterprise@731fe3b)) * remove eslint, update gax, fix generated protos, run the generator ([#155](googleapis/nodejs-recaptcha-enterprise#155)) ([21b09f5](googleapis/nodejs-recaptcha-enterprise@21b09f5)) * remove key management API ([#366](googleapis/nodejs-recaptcha-enterprise#366)) ([44a5a4b](googleapis/nodejs-recaptcha-enterprise@44a5a4b)) * rename parent to project in SearchRelatedAccountGroupMembershipsRequest ([#370](googleapis/nodejs-recaptcha-enterprise#370)) ([aad0883](googleapis/nodejs-recaptcha-enterprise@aad0883)) * synth.py clean up for multiple version ([#172](googleapis/nodejs-recaptcha-enterprise#172)) ([ee1c250](googleapis/nodejs-recaptcha-enterprise@ee1c250)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#299](googleapis/nodejs-recaptcha-enterprise#299)) ([6787e23](googleapis/nodejs-recaptcha-enterprise@6787e23)) * use compatible version of google-gax ([dfb174a](googleapis/nodejs-recaptcha-enterprise@dfb174a)) * use require() to load JSON protos ([#273](googleapis/nodejs-recaptcha-enterprise#273)) ([fdbc0fe](googleapis/nodejs-recaptcha-enterprise@fdbc0fe)) ### Build System * update library to use Node 12 ([#374](googleapis/nodejs-recaptcha-enterprise#374)) ([4042ae2](googleapis/nodejs-recaptcha-enterprise@4042ae2)) * upgrade engines field to >=8.10.0 ([#2](googleapis/nodejs-recaptcha-enterprise#2)) ([94d6a49](googleapis/nodejs-recaptcha-enterprise@94d6a49)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces the v1 API surface.