Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull gRPC from google-gax #71

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Pull gRPC from google-gax #71

merged 2 commits into from
Feb 16, 2018

Conversation

stephenplusplus
Copy link
Contributor

Fixes #70

@stephenplusplus
Copy link
Contributor Author

One sec, going to get rid of grpc.

@stephenplusplus stephenplusplus added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 16, 2018
@codecov
Copy link

codecov bot commented Feb 16, 2018

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         849    849           
=====================================
  Hits          849    849
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b004b6f...85634bf. Read the comment docs.

@alexander-fenster
Copy link
Contributor

I wonder if we can check if 1.9.x works instead. They claim to have fixed all the issues that affected us and ask to verify. (I'm going to try it for google-gax and see if firestore works first)

@stephenplusplus stephenplusplus removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 16, 2018
@stephenplusplus stephenplusplus changed the title Downgrade gRPC Pull gRPC from google-gax Feb 16, 2018
@stephenplusplus
Copy link
Contributor Author

That's good news. My latest change to this PR will pull gRPC from the google-gax package, so this should be a fix for now and a fix for when we upgrade to a new version.

@stephenplusplus stephenplusplus merged commit 6b0d7de into master Feb 16, 2018
@stephenplusplus stephenplusplus deleted the spp--downgrade-grpc branch February 16, 2018 19:00
@stephenplusplus
Copy link
Contributor Author

Issue about when to upgrade gRPC: googleapis/gax-nodejs#188

feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* fix(package): update @google-cloud/common to version 0.17.0

* Update package locks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants