-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull gRPC from google-gax #71
Conversation
One sec, going to get rid of grpc. |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 849 849
=====================================
Hits 849 849
Continue to review full report at Codecov.
|
I wonder if we can check if 1.9.x works instead. They claim to have fixed all the issues that affected us and ask to verify. (I'm going to try it for google-gax and see if firestore works first) |
That's good news. My latest change to this PR will pull gRPC from the google-gax package, so this should be a fix for now and a fix for when we upgrade to a new version. |
Issue about when to upgrade gRPC: googleapis/gax-nodejs#188 |
* fix(package): update @google-cloud/common to version 0.17.0 * Update package locks
Fixes #70