Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KiB, not MiB for ack size limits #1999

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Nov 12, 2024

Fixes a unit issue found in this other PR:

#1963

@feywind feywind requested review from a team as code owners November 12, 2024 21:38
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Nov 12, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2024
@feywind feywind merged commit 798270d into googleapis:main Nov 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants