Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add schema revision samples #1870

Merged
merged 33 commits into from
Jan 31, 2024
Merged

feat: add schema revision samples #1870

merged 33 commits into from
Jan 31, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jan 5, 2024 •
edited
Loading

This adds support for easily getting a schema gapic client, along with samples for schema revisions.

@feywind feywind requested review from a team as code owners January 5, 2024 19:23
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 5, 2024
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Jan 5, 2024
@feywind feywind changed the title feat: add schema revision wrappers and new samples feat: add schema revision samples Jan 8, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 10, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
hongalex
hongalex approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These samples look good. I think there are a few missing ones,most important is probably pubsub_get_schema_revision but also pubsub_commit_proto_schema and pubsub_subscribe_avro_records_with_revisions. The first two should probably go in this PR, while the latter two can be in a separate PR?

kamalaboulhosn
kamalaboulhosn approved these changes Jan 18, 2024
View reviewed changes
samples/README.md Outdated Show resolved Hide resolved
samples/deleteSchemaRevision.js Outdated Show resolved Hide resolved
samples/typescript/deleteSchemaRevision.ts Outdated Show resolved Hide resolved
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 22, 2024
@feywind
Copy link
Collaborator Author

feywind commented Jan 22, 2024

These samples look good. I think there are a few missing ones,most important is probably pubsub_get_schema_revision but also pubsub_commit_proto_schema and pubsub_subscribe_avro_records_with_revisions. The first two should probably go in this PR, while the latter two can be in a separate PR?

Hmm, those didn't make it into my hotlist. I'll just add them in this PR.

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@feywind feywind added the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 044e149 into googleapis:main Jan 31, 2024
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2024
@release-please release-please bot mentioned this pull request Jan 31, 2024
Merged
@feywind feywind deleted the schema-revisions branch January 31, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feywind @kamalaboulhosn @hongalex