Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack and install: "before all" hook: should be able to use the d.ts for "should be able to webpack the library" failed #489

Closed
flaky-bot bot opened this issue Oct 11, 2022 · 2 comments
Assignees
Labels
flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 11, 2022

Note: #422 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 5c9f58d
buildURL: Build Status, Sponge
status: failed

Test output
Command failed with exit code 1: npm install
Error: Command failed with exit code 1: npm install
    at makeError (node_modules/execa/lib/error.js:60:11)
    at handlePromise (node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Context. (build/system-test/test.kitchen.js:45:9)
        -> /workspace/system-test/test.kitchen.ts:46:5
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 11, 2022
@sofisl sofisl assigned danielbankhead and unassigned sofisl Oct 13, 2022
@sofisl
Copy link
Contributor

sofisl commented Oct 13, 2022

Seems related to: googleapis/gaxios#506

@danielbankhead
Copy link
Contributor

Looks fine now: #490

Definitely a transient dependency issue. Next time this happens we should capture the root issue by running the system-test locally (gaxios seems to have non-side effect system-tests, see googleapis/gaxios#506 & googleapis/gaxios#507). This way we can determine how to make this less flaky in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants