Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore client retries a transaction when a document already exists #889

Closed
mad-it opened this issue Jan 17, 2020 · 2 comments · Fixed by #953
Closed

Firestore client retries a transaction when a document already exists #889

mad-it opened this issue Jan 17, 2020 · 2 comments · Fixed by #953
Assignees
@schmidt-sebastian
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mad-it
Copy link

mad-it commented Jan 17, 2020

This issue relates to the fix introduced for #827

Current behavior

When a document already exists, if one tries create a document using the same path with create() inside of a transaction, the transaction will keep retrying until it runs out of attempts.

Expected behavior

When a document is created with create() inside of a transaction, the transaction should intermediately terminate and throw the error.

Environment details

  • OS: Ubuntu 19.10
  • Node.js version: 10.18.0
  • npm version:6.12
  • @google-cloud/firestore version: 3.4.0
@schmidt-sebastian schmidt-sebastian added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 17, 2020
@schmidt-sebastian schmidt-sebastian self-assigned this Jan 22, 2020
@schmidt-sebastian
Copy link
Contributor

Thanks for reporting. We will try to address this shortly.

@google-cloud-label-sync google-cloud-label-sync bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jan 30, 2020
@schmidt-sebastian
Copy link
Contributor

Note: This is next on my list, but I will be out on vacation until Feb 18.

@schmidt-sebastian schmidt-sebastian mentioned this issue Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: base transaction retries on error codes googleapis/nodejs-firestore
2 participants
@mad-it @schmidt-sebastian