From adfe68e194d518369d5b4f89e9be89f948efbdbb Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Sat, 29 May 2021 13:55:39 -0700 Subject: [PATCH] fix: GoogleAdsError missing using generator version after 1.3.0 (#1526) [PR](https://github.com/googleapis/gapic-generator-typescript/pull/878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Author: Google APIs Source-Date: Tue May 25 11:51:53 2021 -0700 Source-Repo: googleapis/googleapis Source-Sha: 95fa72fdd0d69b02d72c33b37d1e4cc66d4b1446 Source-Link: https://github.com/googleapis/googleapis/commit/95fa72fdd0d69b02d72c33b37d1e4cc66d4b1446 --- dev/src/v1/firestore_admin_client.ts | 2 ++ dev/src/v1/firestore_client.ts | 2 ++ dev/src/v1beta1/firestore_client.ts | 2 ++ synth.metadata | 6 +++--- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/dev/src/v1/firestore_admin_client.ts b/dev/src/v1/firestore_admin_client.ts index 709830cf6..5343adc33 100644 --- a/dev/src/v1/firestore_admin_client.ts +++ b/dev/src/v1/firestore_admin_client.ts @@ -143,6 +143,8 @@ export class FirestoreAdminClient { } if (!opts.fallback) { clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`); + } else if (opts.fallback === 'rest') { + clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`); } if (opts.libName && opts.libVersion) { clientHeader.push(`${opts.libName}/${opts.libVersion}`); diff --git a/dev/src/v1/firestore_client.ts b/dev/src/v1/firestore_client.ts index 3d9020996..0f3525328 100644 --- a/dev/src/v1/firestore_client.ts +++ b/dev/src/v1/firestore_client.ts @@ -146,6 +146,8 @@ export class FirestoreClient { } if (!opts.fallback) { clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`); + } else if (opts.fallback === 'rest') { + clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`); } if (opts.libName && opts.libVersion) { clientHeader.push(`${opts.libName}/${opts.libVersion}`); diff --git a/dev/src/v1beta1/firestore_client.ts b/dev/src/v1beta1/firestore_client.ts index b2d3c7ada..0da6be8e3 100644 --- a/dev/src/v1beta1/firestore_client.ts +++ b/dev/src/v1beta1/firestore_client.ts @@ -149,6 +149,8 @@ export class FirestoreClient { } if (!opts.fallback) { clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`); + } else if (opts.fallback === 'rest') { + clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`); } if (opts.libName && opts.libVersion) { clientHeader.push(`${opts.libName}/${opts.libVersion}`); diff --git a/synth.metadata b/synth.metadata index 849ca008c..c87b0f08d 100644 --- a/synth.metadata +++ b/synth.metadata @@ -4,15 +4,15 @@ "git": { "name": ".", "remote": "https://github.com/googleapis/nodejs-firestore.git", - "sha": "aa92a1545a64e1164d5454c24fb38fb99aa1fd24" + "sha": "c4096affaa69017ff1515d02631fd68614605528" } }, { "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "6fa858c6489b1bbc505a7d7afe39f2dc45819c38", - "internalRef": "372656503" + "sha": "95fa72fdd0d69b02d72c33b37d1e4cc66d4b1446", + "internalRef": "375759421" } }, {