Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

typescript consumer tests: should have correct type signature for typescript users failed #359

Closed
flaky-bot bot opened this issue Oct 27, 2023 · 3 comments
Labels
api: datastore Issues related to the googleapis/nodejs-datastore-session API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 27, 2023

Note: #337 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 96685fd
buildURL: Build Status, Sponge
status: failed

Test output
Command failed with exit code 2: npx tsc --strict index.ts
node_modules/google-auth-library/build/src/util.d.ts(134,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
Error: Command failed with exit code 2: npx tsc --strict index.ts
node_modules/google-auth-library/build/src/util.d.ts(134,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
    at makeError (node_modules/execa/lib/error.js:60:11)
    at handlePromise (node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at null.prepareTarget (node_modules/pack-n-play/src/pack-n-test.ts:147:7)
    at null.packNTest (node_modules/pack-n-play/src/pack-n-test.ts:105:5)
    at Context. (system-test/install.ts:36:5)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 27, 2023
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore-session API. label Oct 27, 2023
@danielbankhead
Copy link

@flaky-bot flaky-bot bot reopened this Nov 1, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Nov 1, 2023
Copy link
Author

flaky-bot bot commented Nov 1, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: 96685fd
buildURL: Build Status, Sponge
status: failed

Test output
Command failed with exit code 2: npx tsc --strict index.ts
node_modules/google-auth-library/build/src/util.d.ts(134,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
Error: Command failed with exit code 2: npx tsc --strict index.ts
node_modules/google-auth-library/build/src/util.d.ts(134,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
    at makeError (node_modules/execa/lib/error.js:60:11)
    at handlePromise (node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at null.prepareTarget (node_modules/pack-n-play/src/pack-n-test.ts:147:7)
    at null.packNTest (node_modules/pack-n-play/src/pack-n-test.ts:105:5)
    at Context. (system-test/install.ts:36:5)

@danielbankhead
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: datastore Issues related to the googleapis/nodejs-datastore-session API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant