fix: improve retry logic for streaming API calls #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
…ngs field PiperOrigin-RevId: 590940407 Source-Link: googleapis/googleapis@fb027c8 Source-Link: googleapis/googleapis-gen@f0728cd Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjA3MjhjZGEyMjdiMzg4MzU4MjJjNGU1NTE5ZTU2OGNlOGQyYjVhYyJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
the
api: bigtable
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: m
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
PiperOrigin-RevId: 591912877 Source-Link: googleapis/googleapis@f6505fe Source-Link: googleapis/googleapis-gen@7499187 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzQ5OTE4NzQxNWY4ZDQwNWVmMGQ0NmRkNmZmNjA4YjEyNWM1M2M4ZiJ9
gcf-owl-bot
bot
changed the title
trusted-contributions-gcf
bot
added
kokoro:force-run
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
product-auto-label
bot
added
size: xl
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Don’t modify the gaxOptions parameter in place and pass it down. This change makes it so that changes to gax options downstream will not affect gaxOptions in this layer of the call stack which is desirable and which also allows the failing test to pass.
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
This reverts commit aa0c46b.
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
This was referenced Jan 22, 2024
This reverts commit 3cadbe0.
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
danieljbruce
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: update typescript generator version to 4.3.0
The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.
PiperOrigin-RevId: 599622271
Source-Link: googleapis/googleapis@6239c21
Source-Link: https://github.com/googleapis/googleapis-gen/commit/da13d8222d3ba33734501999864458640f1405ae
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGExM2Q4MjIyZDNiYTMzNzM0NTAxOTk5ODY0NDU4NjQwZjE0MDVhZSJ9
BEGIN_NESTED_COMMIT
feat: configure PHP client to generate new surface
PiperOrigin-RevId: 599228576
Source-Link: googleapis/googleapis@ef54eaf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4d0d81b7822e2f361de6d6e01b375ccc9af3e109
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGQwZDgxYjc4MjJlMmYzNjFkZTZkNmUwMWIzNzVjY2M5YWYzZTEwOSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update comment for
AccountVerificationInfo.usernamePiperOrigin-RevId: 598888823
Source-Link: googleapis/googleapis@955ff0a
Source-Link: https://github.com/googleapis/googleapis-gen/commit/8b0b992cdca00419cdf4433d6bbe3cf3e93f1dd4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIwYjk5MmNkY2EwMDQxOWNkZjQ0MzNkNmJiZTNjZjNlOTNmMWRkNCJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Adding feature flags for routing cookie and retry info
PiperOrigin-RevId: 591912877
Source-Link: googleapis/googleapis@f6505fe
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7499187415f8d405ef0d46dd6ff608b125c53c8f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzQ5OTE4NzQxNWY4ZDQwNWVmMGQ0NmRkNmZmNjA4YjEyNWM1M2M4ZiJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Modify ModifyColumnFamiliesRequest proto to expose ignore_warnings field
PiperOrigin-RevId: 590940407
Source-Link: googleapis/googleapis@fb027c8
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f0728cda227b38835822c4e5519e568ce8d2b5ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjA3MjhjZGEyMjdiMzg4MzU4MjJjNGU1NTE5ZTU2OGNlOGQyYjVhYyJ9
END_NESTED_COMMIT