fix: Out of order read rows fix #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit emits an error if the chunk transformer recieves keys that are out of order. It also pulls some comparison functions into a utility file because now those functions are used by the chunk transformer too.
This commit makes it so that when the client emits an error as a result of rows that are out of order, that the error is sent back to the test runner as an rpc message instead of an rpc error. This is done to stay consistent with the test proxy in Java and allows the TestReadRows_NoRetry_OutOfOrderError test case to pass.
product-auto-label
bot
added
size: m
danieljbruce
changed the title
danieljbruce
changed the title
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
ruyadorno
reviewed
Feb 6, 2023
src/chunktransformer.ts
Outdated
| typeof lastRowKey !== 'undefined' && | ||
| TableUtils.lessThanOrEqualTo(newRowKey as string, lastRowKey as string) | ||
| ) { | ||
| errorMessage = 'key must be strictly increasing'; |
There was a problem hiding this comment.
What about a more friendly message, e.g: A row key must be strictly increasing
ruyadorno
approved these changes
Feb 6, 2023
The error message gets changed to match what is suggested in the pull request to be similar to other errors.
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client changes:
Emits an error if the chunk transformer receives keys that are out of order. The chunk transformer is a stream that data passes through before it reaches the stream that has the handlers for errors and retries.
Also pulls some comparison functions into a utility file because now those functions are used by the chunk transformer to check to see if rows are in order. They are still used by the
table.tsfile, but are available in both places now.Test proxy changes:
Makes it so that when the client emits an error as a result of rows that are out of order, that the error is sent back to the test runner as an rpc message instead of an rpc error. This is done to stay consistent with the test proxy in Java and allows the TestReadRows_NoRetry_OutOfOrderError test case to pass.