test: ensure Storage instances are closed in ITStorageLifecycleTest (#…

…2246)

Looking at CI logs I noticed grpc was logging a leaked channel pool. The storage instance wasn't being closed in these tests.

google-cloud-storage/src/test/java/com/google/cloud/storage/ITStorageLifecycleTest.java

@@ -66,12 +66,12 @@ public void grpc() throws Exception {
     service1.close();
 
     // expect a new instance to be returned
-    Storage service3 = options.getService();
-
-    assertThat(service3).isNotSameInstanceAs(service1);
-    // make sure an RPC can be done
-    StreamSupport.stream(service3.list().iterateAll().spliterator(), false)
-        .collect(Collectors.toList());
+    try (Storage service3 = options.getService()) {
+      assertThat(service3).isNotSameInstanceAs(service1);
+      // make sure an RPC can be done
+      StreamSupport.stream(service3.list().iterateAll().spliterator(), false)
+          .collect(Collectors.toList());
+    }
   }
 
   @Test
@@ -95,11 +95,12 @@ public void http() throws Exception {
     service1.close(); // this should be a no-op for http
 
     // expect the original instance to still be returned
-    Storage service3 = options.getService();
+    try (Storage service3 = options.getService()) {
 
-    assertThat(service3).isSameInstanceAs(service1);
-    // make sure an RPC can be done
-    StreamSupport.stream(service3.list().iterateAll().spliterator(), false)
-        .collect(Collectors.toList());
+      assertThat(service3).isSameInstanceAs(service1);
+      // make sure an RPC can be done
+      StreamSupport.stream(service3.list().iterateAll().spliterator(), false)
+          .collect(Collectors.toList());
+    }
   }
 }