From 4ffd639a12198be32b05b728801ac5a8d9b8a797 Mon Sep 17 00:00:00 2001 From: JesseLovelace <43148100+JesseLovelace@users.noreply.github.com> Date: Wed, 10 Apr 2024 09:52:31 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: BenWhitehead --- .../java/com/google/cloud/storage/GrpcStorageOptions.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java index 9b6a29756d..d5c34fcd33 100644 --- a/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java +++ b/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java @@ -1003,7 +1003,7 @@ public void close() throws IOException { } } - static class ZeroCopyReadinessChecker { + static final class ZeroCopyReadinessChecker { private static final boolean isZeroCopyReady; static { @@ -1021,7 +1021,7 @@ static class ZeroCopyReadinessChecker { Class detachableClass = Class.forName(detachableClassName); detachableClassExists = (detachableClass != null); } catch (ClassNotFoundException ex) { - // Should cause false to be returned + // leaves detachableClassExists false } // Check whether com.google.protobuf.UnsafeByteOperations exists? boolean unsafeByteOperationsClassExists = false; @@ -1034,7 +1034,7 @@ static class ZeroCopyReadinessChecker { Class unsafeByteOperationsClass = Class.forName(unsafeByteOperationsClassName); unsafeByteOperationsClassExists = (unsafeByteOperationsClass != null); } catch (ClassNotFoundException ex) { - // Should cause false to be returned + // leaves unsafeByteOperationsClassExists false } isZeroCopyReady = detachableClassExists && unsafeByteOperationsClassExists; }