From 4b8088162e06351929a3233d1be5719bee146645 Mon Sep 17 00:00:00 2001 From: BenWhitehead Date: Mon, 2 Oct 2023 17:52:38 -0400 Subject: [PATCH] docs: reorder columns in table of BlobWriteSessionConfigs.java The considerations column being last is cut off in the ultimate rendered javadocs. Move it left before retries and apis used. --- .../storage/BlobWriteSessionConfigs.java | 78 +++++++++---------- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobWriteSessionConfigs.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobWriteSessionConfigs.java index e07043e53e..e3ca3390db 100644 --- a/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobWriteSessionConfigs.java +++ b/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobWriteSessionConfigs.java @@ -41,10 +41,10 @@ * Strategy * Factory Method(s) * Description + * Transport(s) Supported + * Considerations * Retry Support - * Transports Supported * Cloud Storage API used - * Considerations * * * Default (Chunk based upload) @@ -54,12 +54,7 @@ * full or close. Buffer size is configurable via * {@link DefaultBlobWriteSessionConfig#withChunkSize(int)} * - * - * Each chunk is retried up to the limitations specified in - * {@link StorageOptions#getRetrySettings()} - * * gRPC - * Resumable Upload * The network will only be used for the following operations: *
    *
  1. Creating the Resumable Upload Session
    2. @@ -71,6 +66,11 @@ * *
* + * + * Each chunk is retried up to the limitations specified in + * {@link StorageOptions#getRetrySettings()} + * + * Resumable Upload * * * Buffer to disk then upload @@ -85,12 +85,7 @@ * Buffer bytes to a temporary file on disk. On {@link WritableByteChannel#close() close()} * upload the entire files contents to Cloud Storage. Delete the temporary file. * - * - * Upload the file in the fewest number of RPC possible retrying within the limitations - * specified in {@link StorageOptions#getRetrySettings()} - * * gRPC - * Resumable Upload * *
    *
  1. A Resumable Upload Session will be used to upload the file on disk.
    2. @@ -100,6 +95,11 @@ * *
* + * + * Upload the file in the fewest number of RPC possible retrying within the limitations + * specified in {@link StorageOptions#getRetrySettings()} + * + * Resumable Upload * * * Journal to disk while uploading @@ -110,12 +110,7 @@ * retryable error query the offset of the Resumable Upload Session, then open the recovery * file from the offset and transmit the bytes to Cloud Storage. * - * - * Opening the stream for upload will be retried up to the limitations specified in {@link StorageOptions#getRetrySettings()} - * All bytes are buffered to disk and allow for recovery from any arbitrary offset. - * * gRPC - * Resumable Upload * *
    *
  1. @@ -133,6 +128,11 @@ *
    2. *
* + * + * Opening the stream for upload will be retried up to the limitations specified in {@link StorageOptions#getRetrySettings()} + * All bytes are buffered to disk and allow for recovery from any arbitrary offset. + * + * Resumable Upload * * * Parallel Composite Upload @@ -141,30 +141,8 @@ * Break the stream of bytes into smaller part objects uploading each part in parallel. Then * composing the parts together to make the ultimate object. * - * - * Automatic retires will be applied for the following: - *
    - *
  1. Creation of each individual part
    2. - *
  2. Performing an intermediary compose
    3. - *
  3. Performing a delete to cleanup each part and intermediary compose object
    4. - *
- * - * Retrying the creation of the final object is contingent upon if an appropriate precondition - * is supplied when calling {@link Storage#blobWriteSession(BlobInfo, BlobWriteOption...)}. - * Either {@link BlobTargetOption#doesNotExist()} or {@link Storage.BlobTargetOption#generationMatch(long)} - * should be specified in order to make the final request idempotent. - *

Each operation will be retried up to the limitations specified in {@link StorageOptions#getRetrySettings()} - * * gRPC * - *

- * - * *
    *
  1. * Performing parallel composite uploads costs more money. @@ -217,6 +195,28 @@ *
    2. *
* + * + * Automatic retires will be applied for the following: + *
    + *
  1. Creation of each individual part
    2. + *
  2. Performing an intermediary compose
    3. + *
  3. Performing a delete to cleanup each part and intermediary compose object
    4. + *
+ * + * Retrying the creation of the final object is contingent upon if an appropriate precondition + * is supplied when calling {@link Storage#blobWriteSession(BlobInfo, BlobWriteOption...)}. + * Either {@link BlobTargetOption#doesNotExist()} or {@link Storage.BlobTargetOption#generationMatch(long)} + * should be specified in order to make the final request idempotent. + *

Each operation will be retried up to the limitations specified in {@link StorageOptions#getRetrySettings()} + * + * + *

+ * * * *