Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add LockHint feature #3588

Merged
merged 4 commits into from
Jan 9, 2025
Merged

feat: add LockHint feature #3588

merged 4 commits into from
Jan 9, 2025

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Jan 9, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/388699606 ☕️

If you write sample code, please follow the samples format.

@rahul2393 rahul2393 requested a review from a team as a code owner January 9, 2025 07:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 9, 2025
@rahul2393 rahul2393 changed the title feat: add LockHint feature #10382 feat: add LockHint feature Jan 9, 2025
@rahul2393 rahul2393 force-pushed the support-read-lockhint branch from 659d8b8 to 02fd8fb Compare January 9, 2025 07:47
@rahul2393
Copy link
Contributor Author

rahul2393 commented Jan 9, 2025 •
edited
Loading

@mayurkale22 any specific reason PR was not raised in Java, I see you raised for Go
googleapis/google-cloud-go#10382

@rahul2393 rahul2393 merged commit 326442b into main Jan 9, 2025
34 checks passed
@rahul2393 rahul2393 deleted the support-read-lockhint branch January 9, 2025 13:38
@release-please release-please bot mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakthivelmanii sakthivelmanii sakthivelmanii approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul2393 @sakthivelmanii