Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test issue due to AbortedException. #2925

Merged
merged 20 commits into from
Feb 23, 2024
Merged

fix: flaky test issue due to AbortedException. #2925

merged 20 commits into from
Feb 23, 2024

Conversation

arpan14
Copy link
Contributor

@arpan14 arpan14 commented Feb 23, 2024 •
edited
Loading

Fixes - #2133

By default AbortedException is not a retryable exception and hence getRetryDelayInMillis() will return -1. Hence, removing the assertion statement.

Error Trace

Caused by: expected not to be: -1
	at com.google.cloud.spanner.it.ITTransactionTest.lambda$readAbort$7(ITTransactionTest.java:341)
	at com.google.cloud.spanner.TransactionRunnerImpl.lambda$runInternal$0(TransactionRunnerImpl.java:986)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:103)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:76)

arpan14 and others added 19 commits February 8, 2023 12:22
@arpan14
fix: prevent illegal negative timeout values into thread sleep() meth…
edc5bbf 
…od while retrying exceptions in unit tests.

* For details on issue see - googleapis#2206
@arpan14
Merge pull request #1 from arpan14/retryerror
49a85df 
fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.
@arpan14
Fixing lint issues.
4cd497b
@arpan14
Merge branch 'googleapis:main' into main
4a6aa8e
@arpan14
Merge branch 'googleapis:main' into main
b2aa09d
@arpan14
Merge branch 'googleapis:main' into main
8d6d71e
@arpan14
Merge branch 'googleapis:main' into main
77e6e7d
@arpan14
Merge branch 'googleapis:main' into main
e8b7fad
@arpan14
Merge branch 'googleapis:main' into main
8aa84e1
@arpan14
Merge branch 'googleapis:main' into main
57fd405
@arpan14
Merge branch 'googleapis:main' into main
1253563
@arpan14
Merge branch 'googleapis:main' into main
d4f6a60
@arpan14
Merge branch 'googleapis:main' into main
3efaf7c
@arpan14
Merge branch 'googleapis:main' into main
f41b39f
@arpan14
Merge branch 'googleapis:main' into main
7e3287f
@arpan14
Merge branch 'googleapis:main' into main
7edd24d
@arpan14
Merge branch 'googleapis:main' into main
fe3649b
@arpan14
Merge branch 'googleapis:main' into main
ae0dbc9
@arpan14
fix: flaky test issue due to AbortedException.
991f930
@arpan14 arpan14 requested a review from a team as a code owner February 23, 2024 13:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 23, 2024
@arpan14 arpan14 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@arpan14 arpan14 merged commit cd34c1d into googleapis:main Feb 23, 2024
25 of 26 checks passed
@arpan14 arpan14 deleted the flaky-test branch February 23, 2024 14:01
@release-please release-please bot mentioned this pull request Feb 23, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 4, 2024
@release-please
chore(main): release 6.61.0 (#2926)
95bad55 
🤖 I have created a release *beep* *boop*
---


## [6.61.0](https://togithub.com/googleapis/java-spanner/compare/v6.60.1...v6.61.0) (2024-03-04)


### Features

* Support float32 type ([#2894](https://togithub.com/googleapis/java-spanner/issues/2894)) ([19b7976](https://togithub.com/googleapis/java-spanner/commit/19b79764294e938ad85d02b7c0662db6ec3afeda))


### Bug Fixes

* Flaky test issue due to AbortedException. ([#2925](https://togithub.com/googleapis/java-spanner/issues/2925)) ([cd34c1d](https://togithub.com/googleapis/java-spanner/commit/cd34c1d3ae9a5a36f4d5516dcf7c3667a9cf015a))


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([#2935](https://togithub.com/googleapis/java-spanner/issues/2935)) ([f8f835a](https://togithub.com/googleapis/java-spanner/commit/f8f835a9da705605c492e232a58276c39d1d7e6c))
* Update dependency org.json:json to v20240303 ([#2936](https://togithub.com/googleapis/java-spanner/issues/2936)) ([1d7044e](https://togithub.com/googleapis/java-spanner/commit/1d7044e97d16f5296b7de020cd24b11cbe2a7df0))


### Documentation

* Samples and tests for backup Admin APIs and overall spanner Admin APIs. ([#2882](https://togithub.com/googleapis/java-spanner/issues/2882)) ([de13636](https://togithub.com/googleapis/java-spanner/commit/de1363645e03f46deed5be41f90ddfed72766751))
* Update all public documents to use auto-generated admin clients. ([#2928](https://togithub.com/googleapis/java-spanner/issues/2928)) ([ccb110a](https://togithub.com/googleapis/java-spanner/commit/ccb110ad6835557870933c95cfd76580fd317a16))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpan14 @olavloite