Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITInstanceAdminTest #update / #updateViaEntity fail when two tests are running simultaneously #1626

Closed
thiagotnunes opened this issue Jan 4, 2022 · 2 comments · Fixed by #1977
Closed

ITInstanceAdminTest #update / #updateViaEntity fail when two tests are running simultaneously #1626

thiagotnunes opened this issue Jan 4, 2022 · 2 comments · Fixed by #1977
Assignees
@gauravpurohit06
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@thiagotnunes
Copy link
Contributor

The update and updateViaEntity tests update the current instance display name to a random one. If there are two tests running simultaneously the assertions might fail, because the updated name can match the wrong display name.

We need to fix these tests so that they are self-contained.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jan 4, 2022
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 4, 2022
@ansh0l ansh0l added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 23, 2022
@ansh0l ansh0l assigned rajatbhatta and unassigned ansh0l Mar 26, 2022
@mpeddada1 mpeddada1 mentioned this issue Jul 6, 2022
Merged
4 tasks
@ansh0l
Copy link
Contributor

ansh0l commented Jul 12, 2022

cc @rajatbhatta to take a look at the related issue

@mpeddada1
Copy link
Contributor

thanks for looking into this @rajatbhatta! Any update on this?

@gauravpurohit06 gauravpurohit06 mentioned this issue Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravpurohit06 gauravpurohit06

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Creating dummy spanner instance for ITInstanceAdminTest gauravpurohit06/java-spanner
6 participants
@thiagotnunes @ansh0l @gauravpurohit06 @yoshi-automation @mpeddada1 @rajatbhatta