Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move handwritten libraries to use version of maven-javadoc-plugin from java-shared-config #673

Closed
alicejli opened this issue Oct 4, 2023 · 2 comments
Closed

Move handwritten libraries to use version of maven-javadoc-plugin from java-shared-config #673

alicejli opened this issue Oct 4, 2023 · 2 comments
Assignees
@alicejli
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@alicejli
Copy link
Contributor

alicejli commented Oct 4, 2023

See #661
@alicejli alicejli self-assigned this Oct 4, 2023
@mpeddada1 mpeddada1 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 5, 2023
@alicejli
Copy link
Contributor Author

alicejli commented Oct 5, 2023

@suztomo fixed the bigtable breakage by removing their explicit version declaration of the maven-javadoc-plugin to rely on the java-shared-config version (which has been reverted back to 3.5.0): googleapis/java-bigtable#1950

This will need to be replicated for the following handwritten libraries:

  1. google-cloud-bigquerystorage
  2. google-cloud-bigquery
  3. google-cloud-firestore
  4. google-cloud-logging
  5. google-cloud-logging-logback
  6. google-cloud-pubsub
  7. google-cloud-pubsublite
  8. google-cloud-spanner
  9. google-cloud-spanner-jdbc

This was referenced Oct 9, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alicejli alicejli changed the title Debug why maven-javadoc-plugin v3.6.0 breaks javadoc generation with the doclet Move handwritten libraries to use version of maven-javadoc-plugin from java-shared-config Oct 9, 2023
@alicejli alicejli mentioned this issue Oct 9, 2023
Closed
@alicejli alicejli added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 9, 2023
@alicejli
Copy link
Contributor Author

These have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alicejli alicejli

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alicejli @mpeddada1