This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
docs(samples): Refactoring product package (CRUD) #417
Merged
alicejli
merged 15 commits into
googleapis:main
from
sborisenkox:refactoring-products-crud
Jul 13, 2022
Merged
docs(samples): Refactoring product package (CRUD) #417
alicejli
merged 15 commits into
googleapis:main
from
sborisenkox:refactoring-products-crud
Jul 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Pull request size is large.
api: retail
Issues related to the googleapis/java-retail API.
samples
Issues that are directly related to samples.
labels
Apr 25, 2022
4 tasks
chenlei1216
approved these changes
Apr 25, 2022
// safely clean up any remaining background resources. | ||
try (ProductServiceClient serviceClient = ProductServiceClient.create()) { | ||
serviceClient.removeFulfillmentPlacesAsync(removeFulfillmentRequest); | ||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use //
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
serviceClient.setInventoryAsync(setInventoryRequest); | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use //
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Shabirmean
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Shabirmean
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 26, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 26, 2022
alicejli
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 13, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 13, 2022
alicejli
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 13, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 13, 2022
alicejli
approved these changes
Jul 13, 2022
alicejli
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 13, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 13, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [2.4.0](v2.3.0...v2.4.0) (2022-08-09) ### Features * allow adding labels in search requests ([70ae250](70ae250)) * allow adding labels in search requests ([70ae250](70ae250)) * allow disabling spell check in search requests ([70ae250](70ae250)) * allow disabling spell check in search requests ([70ae250](70ae250)) * allow enabling recommendation filtering on custom attributes ([70ae250](70ae250)) * allow enabling recommendation filtering on custom attributes ([70ae250](70ae250)) * allow returning min/max values on search numeric facets ([70ae250](70ae250)) * allow returning min/max values on search numeric facets ([70ae250](70ae250)) * allow skiping default branch protection when doing product full import ([70ae250](70ae250)) * allow to return min/max values on search numeric facets ([70ae250](70ae250)) * allow to use serving configs as an alias of placements ([70ae250](70ae250)) * allow using serving configs as an alias of placements ([70ae250](70ae250)) * allow using serving configs as an alias of placements ([70ae250](70ae250)) * new model service to manage recommendation models ([#497](#497)) ([70ae250](70ae250)) * return output BigQuery table on product / event export response ([70ae250](70ae250)) * return output BigQuery table on product / event export response ([70ae250](70ae250)) * support case insensitive match on search facets ([70ae250](70ae250)) * support case insensitive match on search facets ([70ae250](70ae250)) * support case insensitive match on search facets ([70ae250](70ae250)) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-retail/issues/1485)) ([#487](#487)) ([aebd3d2](aebd3d2)) ### Documentation * keep the API doc up-to-date with recent changes ([70ae250](70ae250)) * keep the API doc up-to-date with recent changes ([70ae250](70ae250)) * keep the API doc up-to-date with recent changes ([70ae250](70ae250)) * **samples:** Refactoring product package (CRUD) ([#417](#417)) ([6b1973d](6b1973d)) * **samples:** Refactoring search package ([#415](#415)) ([ae435e0](ae435e0)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#499](#499)) ([9aff3a0](9aff3a0)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#504](#504)) ([82db98b](82db98b)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#507](#507)) ([911ff65](911ff65)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#509](#509)) ([c6a7c65](c6a7c65)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#510](#510)) ([d532bff](d532bff)) * update dependency com.google.code.gson:gson to v2.9.1 ([#500](#500)) ([2af1d50](2af1d50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to googleapis/google-cloud-java
that referenced
this pull request
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [2.4.0](googleapis/java-retail@v2.3.0...v2.4.0) (2022-08-09) ### Features * allow adding labels in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow adding labels in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow disabling spell check in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow disabling spell check in search requests ([2be6d88](googleapis/java-retail@2be6d88)) * allow enabling recommendation filtering on custom attributes ([2be6d88](googleapis/java-retail@2be6d88)) * allow enabling recommendation filtering on custom attributes ([2be6d88](googleapis/java-retail@2be6d88)) * allow returning min/max values on search numeric facets ([2be6d88](googleapis/java-retail@2be6d88)) * allow returning min/max values on search numeric facets ([2be6d88](googleapis/java-retail@2be6d88)) * allow skiping default branch protection when doing product full import ([2be6d88](googleapis/java-retail@2be6d88)) * allow to return min/max values on search numeric facets ([2be6d88](googleapis/java-retail@2be6d88)) * allow to use serving configs as an alias of placements ([2be6d88](googleapis/java-retail@2be6d88)) * allow using serving configs as an alias of placements ([2be6d88](googleapis/java-retail@2be6d88)) * allow using serving configs as an alias of placements ([2be6d88](googleapis/java-retail@2be6d88)) * new model service to manage recommendation models ([#497](googleapis/java-retail#497)) ([2be6d88](googleapis/java-retail@2be6d88)) * return output BigQuery table on product / event export response ([2be6d88](googleapis/java-retail@2be6d88)) * return output BigQuery table on product / event export response ([2be6d88](googleapis/java-retail@2be6d88)) * support case insensitive match on search facets ([2be6d88](googleapis/java-retail@2be6d88)) * support case insensitive match on search facets ([2be6d88](googleapis/java-retail@2be6d88)) * support case insensitive match on search facets ([2be6d88](googleapis/java-retail@2be6d88)) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-retail/issues/1485)) ([#487](googleapis/java-retail#487)) ([ff6af57](googleapis/java-retail@ff6af57)) ### Documentation * keep the API doc up-to-date with recent changes ([2be6d88](googleapis/java-retail@2be6d88)) * keep the API doc up-to-date with recent changes ([2be6d88](googleapis/java-retail@2be6d88)) * keep the API doc up-to-date with recent changes ([2be6d88](googleapis/java-retail@2be6d88)) * **samples:** Refactoring product package (CRUD) ([#417](googleapis/java-retail#417)) ([d0c5f39](googleapis/java-retail@d0c5f39)) * **samples:** Refactoring search package ([#415](googleapis/java-retail#415)) ([f7e3b16](googleapis/java-retail@f7e3b16)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#499](googleapis/java-retail#499)) ([eb0b64d](googleapis/java-retail@eb0b64d)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#504](googleapis/java-retail#504)) ([38ffa21](googleapis/java-retail@38ffa21)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#507](googleapis/java-retail#507)) ([fdd05c6](googleapis/java-retail@fdd05c6)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#509](googleapis/java-retail#509)) ([05f2d9b](googleapis/java-retail@05f2d9b)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#510](googleapis/java-retail#510)) ([6dccbdf](googleapis/java-retail@6dccbdf)) * update dependency com.google.code.gson:gson to v2.9.1 ([#500](googleapis/java-retail#500)) ([4f864e8](googleapis/java-retail@4f864e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: retail
Issues related to the googleapis/java-retail API.
samples
Issues that are directly related to samples.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.