Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add some missing annotations and fix equals/hashcode for DatastoreOptions #1106

Merged
merged 2 commits into from
Jun 9, 2023
Merged

fix: add some missing annotations and fix equals/hashcode for DatastoreOptions #1106

merged 2 commits into from
Jun 9, 2023

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jun 8, 2023

No description provided.

@kolea2 kolea2 requested review from a team as code owners June 8, 2023 15:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Jun 8, 2023
@kolea2 kolea2 changed the title chore(multi db): add some missing annotations and fix equals/hashcode for DatastoreOptions fix: add some missing annotations and fix equals/hashcode for DatastoreOptions Jun 8, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2023
jainsahab
jainsahab approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@jainsahab jainsahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolea2 kolea2 merged commit c4a79ef into googleapis:main Jun 9, 2023
@kolea2 kolea2 deleted the multi-db-fixes branch June 9, 2023 13:48
@release-please release-please bot mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainsahab jainsahab jainsahab approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolea2 @jainsahab