feat!: remove deprecated append method in StreamWriterV2

[yayi-google]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

[codecov]

Codecov Report

Merging #924 (27c5a78) into master (ed33785) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #924      +/-   ##
============================================
- Coverage     80.99%   80.95%   -0.04%     
  Complexity     1021     1021              
============================================
  Files            76       76              
  Lines          5556     5556              
  Branches        426      427       +1     
============================================
- Hits           4500     4498       -2     
- Misses          879      881       +2     
  Partials        177      177              

Impacted Files	Coverage Δ	Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java	96.10% <100.00%> (ø)	39.00 <0.00> (ø)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java	82.79% <0.00%> (-0.46%)	33.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33785...5bdca0e. Read the comment docs.

[stephaniewang526]

Hi @yayi-google -- the change is fine but the PR needs to be feat!: since it indicates a major breaking change.

Please update both the PR subject and the initial commit (which will be used in the release notes).

[yayi-google]

Hi @yayi-google -- the change is fine but the PR needs to be feat!: since it indicates a major breaking change.

Please update both the PR subject and the initial commit (which will be used in the release notes).

Done. Thank you!

[stephaniewang526]

Also this is breaking binary compatability:

Error:  7002: com.google.cloud.bigquery.storage.v1beta2.StreamWriterV2: Method 'public com.google.api.core.ApiFuture append(com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest)' has been removed

To fix this, we need to modify this file -- we can delete these once the client is released (meaning new baseline is established for binary compat check).

[yayi-google]

Done. Thank you!

…

On Tue, Mar 9, 2021 at 8:14 AM Stephanie Wang ***@***.***> wrote: Also this is breaking binary compatability: Error: 7002: com.google.cloud.bigquery.storage.v1beta2.StreamWriterV2: Method 'public com.google.api.core.ApiFuture append(com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest)' has been removed To fix this, we need to modify this file <https://github.com/googleapis/java-bigquerystorage/blob/master/google-cloud-bigquerystorage/clirr-ignored-differences.xml> -- we can delete these once the client is released (meaning new baseline is established for binary compat check). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#924 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASBQVIOKXPB6XHRIA2TCNTDTCY3NHANCNFSM4YWIDM3A> .