docs: user-provided streamOrTableName for default write streams #1155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a broken URL in a sample comment.
Also cleans up the docstrings for
streamOrTableName
inJsonStreamWriter.Builder
.IIUC,
createDefaultStream
can only be set to True onStreamWriter
notJsonStreamWriter
, the language below could mislead devs into thinking otherwise because it's not clear whichbuilder
it refers to.java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java
Lines 185 to 188 in d6c3146
Also it looks like
_default
is not added by client code but by the library.java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java
Lines 267 to 274 in d6c3146
Not sure if I'm making all the right calls here. Thanks for reviewing!
Also see internal cl/381977832.