fix: migrate json writer to use StreamWriterV2 #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerystorage
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
============================================
- Coverage 79.49% 79.48% -0.01%
+ Complexity 701 700 -1
============================================
Files 61 61
Lines 3945 3944 -1
Branches 264 266 +2
============================================
- Hits 3136 3135 -1
Misses 684 684
Partials 125 125
Continue to review full report at Codecov.
|
shollyman
requested review from
stephaniewang526
and removed request for
shollyman and
steffnay
stephaniewang526
suggested changes
May 10, 2021
| @@ -3,27 +3,8 @@ | |||
| <differences> | |||
| <!-- Allow below protobuf changes as non-breaking--> | |||
| <difference> | |||
| <differenceType>8001</differenceType> | |||
There was a problem hiding this comment.
please don't remove any of these existing <difference>s since they are needed to allow protobuf changes to be non-breaking.
stephaniewang526
approved these changes
May 11, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 11, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.20.4](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.20.3...v1.20.4) (2021-05-11) ### Bug Fixes * migrate json writer to use StreamWriterV2 ([#1058](https://www.github.com/googleapis/java-bigquerystorage/issues/1058)) ([586777f](https://www.github.com/googleapis/java-bigquerystorage/commit/586777f289f3dc84d2d6237463f128d278d2465f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#1061](https://www.github.com/googleapis/java-bigquerystorage/issues/1061)) ([d6c3146](https://www.github.com/googleapis/java-bigquerystorage/commit/d6c3146d21282d1e0724583f68a31184d2d7167b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.124.21](https://togithub.com/googleapis/java-storage-nio/compare/v0.124.20...v0.124.21) (2022-11-18) ### Dependencies * Update dependency com.google.cloud:google-cloud-storage to v2.15.1 ([googleapis#1057](https://togithub.com/googleapis/java-storage-nio/issues/1057)) ([88b1aac](https://togithub.com/googleapis/java-storage-nio/commit/88b1aace911f8b2187b5cba246ea13a143bad7ad)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️