Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove schema update capability from jsonwriter and delete related tests #1047

Merged
merged 3 commits into from
May 4, 2021
Merged

Conversation

yirutang
Copy link
Contributor

…ted tests

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and stephaniewang526 April 30, 2021 20:53
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Apr 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #1047 (4610ea9) into master (b100b63) will decrease coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1047      +/-   ##
============================================
- Coverage     80.19%   79.49%   -0.70%     
+ Complexity      710      701       -9     
============================================
  Files            61       61              
  Lines          3963     3945      -18     
  Branches        264      264              
============================================
- Hits           3178     3136      -42     
- Misses          661      684      +23     
- Partials        124      125       +1     
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 68.04% <ø> (-8.49%) 11.00 <0.00> (-3.00)
...gquery/storage/v1beta2/OnSchemaUpdateRunnable.java 0.00% <ø> (-85.72%) 0.00 <0.00> (-4.00)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 80.73% <0.00%> (-3.22%) 31.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100b63...4610ea9. Read the comment docs.

@yirutang
Copy link
Contributor Author

yirutang commented May 4, 2021 via email

@stephaniewang526 stephaniewang526 merged commit 21e399b into googleapis:master May 4, 2021
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…essor job (googleapis#1691) (googleapis#1047)

* chore: install dependencies through requirements file
Source-Link: googleapis/synthtool@35f4cba
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:821ab7aba89af2c7907e29297bba024d4cd5366d0684e5eb463391cdf4edc9ee

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants