Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fast query path support when empty jobId object is passed #2349

Merged
merged 17 commits into from
Nov 11, 2022
Merged

feat: add fast query path support when empty jobId object is passed #2349

merged 17 commits into from
Nov 11, 2022

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Oct 12, 2022 •
edited
Loading

Currently, if a jobID object is passed to the query method, it goes through the slow query path always. This PR allows user to set the location and project ID of the job being created with the JobID object AND take the fast query path if all the conditions for fast query path are met.

Note: If the user specifies the job id string in the job id object being supplied to the query method, the workflow will default to the slow query path and use the job id specified.

@Neenu1995 Neenu1995 requested review from a team and prash-mi October 12, 2022 22:44
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Oct 12, 2022
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2022
@Neenu1995 Neenu1995 changed the title feat: add fast query path support with job location feat: add fast query path support when empty jobId object is passed Oct 13, 2022
@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 4, 2022 20:38
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2022
@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 7, 2022
prash-mi
prash-mi approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@prash-mi prash-mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For the given issue it will take the fast query path and it should avoid the Already Exists error which we saw in the slow query path. However we may want to later analyse(and maybe capture a TODO bug) if the slow query path could still give us such an error (when the operation errors out and is retried, while having any one of the given configs set to not null) . I think we should be good to merge after Seth's comments are addressed.

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@Neenu1995 Neenu1995 merged commit 42c083a into main Nov 11, 2022
@Neenu1995 Neenu1995 deleted the fix-query-path branch November 11, 2022 19:16
@release-please release-please bot mentioned this pull request Nov 11, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 13, 2022
@release-please
chore(main): release 2.20.0 (#2408)
e4d1076 
🤖 I have created a release *beep* *boop*
---


## [2.20.0](https://togithub.com/googleapis/java-bigquery/compare/v2.19.1...v2.20.0) (2022-12-13)


### Features

* Add fast query path support when empty jobId object is passed ([#2349](https://togithub.com/googleapis/java-bigquery/issues/2349)) ([42c083a](https://togithub.com/googleapis/java-bigquery/commit/42c083ac680c657bf3f648fbce81004ecac8be87))
* Next release from main branch is 2.20.0 ([#2405](https://togithub.com/googleapis/java-bigquery/issues/2405)) ([9297a43](https://togithub.com/googleapis/java-bigquery/commit/9297a4359f7b080a60b6bb5873edfd66cd7d2261))


### Dependencies

* Update arrow.version to v10.0.1 ([#2426](https://togithub.com/googleapis/java-bigquery/issues/2426)) ([aff9019](https://togithub.com/googleapis/java-bigquery/commit/aff901904d04a9a35042126a90e2a2826283a3e7))
* Update cloud client dependencies ([#2444](https://togithub.com/googleapis/java-bigquery/issues/2444)) ([7255357](https://togithub.com/googleapis/java-bigquery/commit/7255357fc3bc715ebe15761acbe83c5e33495fdc))
* Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.8.0 ([#2418](https://togithub.com/googleapis/java-bigquery/issues/2418)) ([1ac1653](https://togithub.com/googleapis/java-bigquery/commit/1ac1653ed705fa7173c4a83ab37169fdb15422e3))
* Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.9.0 ([#2441](https://togithub.com/googleapis/java-bigquery/issues/2441)) ([01cc3c3](https://togithub.com/googleapis/java-bigquery/commit/01cc3c3d64884c2d7b68c5099de7c0959c1846db))
* Update dependency com.google.apis:google-api-services-bigquery to v2-rev20221127-2.0.0 ([#2437](https://togithub.com/googleapis/java-bigquery/issues/2437)) ([eb52002](https://togithub.com/googleapis/java-bigquery/commit/eb52002919843ad9341d3f9b06c10e401637b82a))
* Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.12.0 ([#2419](https://togithub.com/googleapis/java-bigquery/issues/2419)) ([c449031](https://togithub.com/googleapis/java-bigquery/commit/c4490315b62606371e134f2a9c2fbfabc60bee03))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#2435](https://togithub.com/googleapis/java-bigquery/issues/2435)) ([c99b215](https://togithub.com/googleapis/java-bigquery/commit/c99b21552e30a509b6220de7a491566dbab086db))
* Update dependency com.google.cloud:google-cloud-storage to v2.15.1 ([#2420](https://togithub.com/googleapis/java-bigquery/issues/2420)) ([baf337a](https://togithub.com/googleapis/java-bigquery/commit/baf337a12e89af73db0c2494e61f271f32e44ed0))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#2424](https://togithub.com/googleapis/java-bigquery/issues/2424)) ([63b5196](https://togithub.com/googleapis/java-bigquery/commit/63b51969dc20747d3dd1f127cc0fcb2d27c9c8c0))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.19 ([#2432](https://togithub.com/googleapis/java-bigquery/issues/2432)) ([396c6dc](https://togithub.com/googleapis/java-bigquery/commit/396c6dc101837a801c7f693f3a3548eb6685feaf))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#2425](https://togithub.com/googleapis/java-bigquery/issues/2425)) ([cd2ae9f](https://togithub.com/googleapis/java-bigquery/commit/cd2ae9f3d2c19be8a375e6be57a7e6b805b1ac4e))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.19 ([#2433](https://togithub.com/googleapis/java-bigquery/issues/2433)) ([bf94087](https://togithub.com/googleapis/java-bigquery/commit/bf940878a7cf602b7f0736335653bc6c479e2df6))
* Update jmh.version to v1.36 ([#2415](https://togithub.com/googleapis/java-bigquery/issues/2415)) ([0676586](https://togithub.com/googleapis/java-bigquery/commit/06765866bf4507f8f6ebbaee28e7dc698f9ba14c))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Dec 20, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prash-mi prash-mi prash-mi approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neenu1995 @shollyman @prash-mi @yoshi-kokoro