Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add googleapis-auth as codeowner team #923

Merged
merged 6 commits into from
Jul 25, 2022
Merged

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jul 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@lqiu96 lqiu96 requested a review from a team as a code owner July 22, 2022 20:05
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 22, 2022
@@ -61,3 +61,5 @@ permissionRules:
permission: admin
- team: yoshi-java
permission: push
- team: googleapis-auth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change might be overridden to this file by the nightly owlbot template sync job, so we may need to add this file to the ignore list in owlbot.py. Is that correct @suztomo ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added Write role to googleapis-auth team via 'Settings'. Edit to .github/sync-repo-settings.yaml is not needed.

I observed OwlBot does not override the file googleapis/synthtool#1494 (comment)

@lqiu96 lqiu96 merged commit d7dc38c into main Jul 25, 2022
@lqiu96 lqiu96 deleted the auth_team_permissions branch July 25, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants