Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalServerReceiver uses PrintWriter #503

Closed
elharo opened this issue Sep 18, 2020 · 2 comments · Fixed by #595
Closed

LocalServerReceiver uses PrintWriter #503

elharo opened this issue Sep 18, 2020 · 2 comments · Fixed by #595
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@elharo
Copy link
Contributor

elharo commented Sep 18, 2020

This causes it to swallow IOExceptions.
@elharo elharo added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 18, 2020
@elharo elharo changed the title LocalServerReceiver uses PrintStream LocalServerReceiver uses PrintWriter Sep 18, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 19, 2020
@danoscarmike danoscarmike added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Sep 21, 2020
@danoscarmike
Copy link

Out of curiosity - what is the fix here? Can we use FileWriter? Or PrintWriter.checkError()?

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Dec 20, 2020
@elharo
Copy link
Contributor Author

elharo commented Jan 11, 2021

don't use PrintWriter is the fix.

@elharo elharo mentioned this issue Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't swallow exceptions in LocalServerReceiver googleapis/google-oauth-java-client
4 participants
@chingor13 @elharo @danoscarmike @yoshi-automation