From da0bf32f08b256a03270ee0447c4dd82151038c3 Mon Sep 17 00:00:00 2001
From: Peter Lamut <inbox@peterlamut.com>
Date: Thu, 20 Jun 2019 15:52:10 +0200
Subject: [PATCH] Make synth operations on PubSub types idempotent

This commit assures that the code block for injecting FlowControl docs
is not added on every synth tool run - it is only added if one does not
exist yet.
---
 pubsub/google/cloud/pubsub_v1/types.py | 66 --------------------------
 pubsub/synth.metadata                  | 10 ++--
 pubsub/synth.py                        | 14 ++++++
 3 files changed, 19 insertions(+), 71 deletions(-)

diff --git a/pubsub/google/cloud/pubsub_v1/types.py b/pubsub/google/cloud/pubsub_v1/types.py
index 1b90bbb7dbbb..0e73ce6b5588 100644
--- a/pubsub/google/cloud/pubsub_v1/types.py
+++ b/pubsub/google/cloud/pubsub_v1/types.py
@@ -104,72 +104,6 @@
     )
 
 
-if sys.version_info >= (3, 5):
-    FlowControl.__doc__ = (
-        "The settings for controlling the rate at which messages are pulled "
-        "with an asynchronous subscription."
-    )
-    FlowControl.max_bytes.__doc__ = (
-        "The maximum total size of received - but not yet processed - messages "
-        "before pausing the message stream."
-    )
-    FlowControl.max_messages.__doc__ = (
-        "The maximum number of received - but not yet processed - messages before "
-        "pausing the message stream."
-    )
-    FlowControl.resume_threshold.__doc__ = (
-        "The relative threshold of the ``max_bytes`` and ``max_messages`` limits "
-        "below which to resume the message stream. Must be a positive number not "
-        "greater than ``1.0``."
-    )
-    FlowControl.max_requests.__doc__ = "Currently not in use."
-    FlowControl.max_request_batch_size.__doc__ = (
-        "The maximum number of requests scheduled by callbacks to process and "
-        "dispatch at a time."
-    )
-    FlowControl.max_request_batch_latency.__doc__ = (
-        "The maximum amount of time in seconds to wait for additional request "
-        "items before processing the next batch of requests."
-    )
-    FlowControl.max_lease_duration.__doc__ = (
-        "The maximum amount of time in seconds to hold a lease on a message "
-        "before dropping it from the lease management."
-    )
-
-
-if sys.version_info >= (3, 5):
-    FlowControl.__doc__ = (
-        "The settings for controlling the rate at which messages are pulled "
-        "with an asynchronous subscription."
-    )
-    FlowControl.max_bytes.__doc__ = (
-        "The maximum total size of received - but not yet processed - messages "
-        "before pausing the message stream."
-    )
-    FlowControl.max_messages.__doc__ = (
-        "The maximum number of received - but not yet processed - messages before "
-        "pausing the message stream."
-    )
-    FlowControl.resume_threshold.__doc__ = (
-        "The relative threshold of the ``max_bytes`` and ``max_messages`` limits "
-        "below which to resume the message stream. Must be a positive number not "
-        "greater than ``1.0``."
-    )
-    FlowControl.max_requests.__doc__ = "Currently not in use."
-    FlowControl.max_request_batch_size.__doc__ = (
-        "The maximum number of requests scheduled by callbacks to process and "
-        "dispatch at a time."
-    )
-    FlowControl.max_request_batch_latency.__doc__ = (
-        "The maximum amount of time in seconds to wait for additional request "
-        "items before processing the next batch of requests."
-    )
-    FlowControl.max_lease_duration.__doc__ = (
-        "The maximum amount of time in seconds to hold a lease on a message "
-        "before dropping it from the lease management."
-    )
-
-
 _shared_modules = [
     http_pb2,
     iam_policy_pb2,
diff --git a/pubsub/synth.metadata b/pubsub/synth.metadata
index 3838907bf04b..eaa99c8f3fb3 100644
--- a/pubsub/synth.metadata
+++ b/pubsub/synth.metadata
@@ -1,19 +1,19 @@
 {
-  "updateTime": "2019-06-19T12:19:44.898368Z",
+  "updateTime": "2019-06-20T13:51:18.842985Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.28.0",
-        "dockerImage": "googleapis/artman@sha256:6ced5a36b08b82a328c69844e629300d58c14067f25cadab47f52542bdef7daf"
+        "version": "0.29.0",
+        "dockerImage": "googleapis/artman@sha256:b79c8c20ee51e5302686c9d1294672d59290df1489be93749ef17d0172cc508d"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "ac13167e31a20314aa05cc9911c95df250880485",
-        "internalRef": "253867808"
+        "sha": "45e125f9e30dc5d45b52752b3ab78dd4f6084f2d",
+        "internalRef": "254026509"
       }
     },
     {
diff --git a/pubsub/synth.py b/pubsub/synth.py
index e9a54a5da10a..c4ce8c90e18c 100644
--- a/pubsub/synth.py
+++ b/pubsub/synth.py
@@ -168,6 +168,20 @@ def _merge_dict(d1, d2):
 )
 
 # document FlowControl settings in Python 3.5+
+
+# ... first remove any existing code that injects the docs
+s.replace(
+    "google/cloud/pubsub_v1/types.py",
+    r"if sys\.version_info >= \(3, 5\):",
+    "",
+)
+s.replace(
+    "google/cloud/pubsub_v1/types.py",
+    r"    FlowControl\..*?__doc__ = \(.*?\)",
+    "",
+    flags=re.DOTALL,
+)
+
 s.replace(
     "google/cloud/pubsub_v1/types.py",
     "FlowControl.__new__.__defaults__ = \(.*?\)",