Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Core: Simplify from_rfc3339 methods #7676

Closed
crwilcox opened this issue Apr 8, 2019 · 0 comments · Fixed by #9641
Closed

API Core: Simplify from_rfc3339 methods #7676

crwilcox opened this issue Apr 8, 2019 · 0 comments · Fixed by #9641
Assignees
@emar-kar
Labels
api: core type: cleanup An internal cleanup or hygiene concern.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Apr 8, 2019

from_rfc3339 doesn't handle Nanos, but from_rfc3339_nanos does. Would it make sense to use the from_rfc3339_nanos implementation for both? It seems to me we could simplify the interface by having one from rfc3339 method.

https://github.com/googleapis/google-cloud-python/blob/master/api_core/google/api_core/datetime_helpers.py#L117

https://github.com/googleapis/google-cloud-python/blob/master/api_core/google/api_core/datetime_helpers.py#L130
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 8, 2019
@sduskis sduskis added type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 16, 2019
This was referenced Jul 24, 2019
Closed
Closed
@emar-kar emar-kar self-assigned this Nov 7, 2019
@emar-kar emar-kar mentioned this issue Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emar-kar emar-kar

Labels
api: core type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
5 participants
@sduskis @tseaver @crwilcox @yoshi-automation @emar-kar