Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] un-constant server timestamp and delete values to support ARRAY_UNION, etc #6551

Closed
crwilcox opened this issue Nov 16, 2018 · 2 comments
Closed

[Firestore] un-constant server timestamp and delete values to support ARRAY_UNION, etc #6551

crwilcox opened this issue Nov 16, 2018 · 2 comments
Assignees
@crwilcox
Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

FieldValue.serverTimestamp() and FieldValue.delete() are exposed as constants, which will become problematic as we add arrayUnion()/arrayRemove()/numericAdd().
@crwilcox crwilcox added api: firestore Issues related to the Firestore API. triaged for GA labels Nov 16, 2018
@crwilcox crwilcox changed the title [Firestore] un-constan t server timestamp and delete values to support ARRAY_UNION, etc [Firestore] un-constant server timestamp and delete values to support ARRAY_UNION, etc Nov 16, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 16, 2018

There is no FieldValue in Python. I am working now to refactor how the various transforms are handled, and do not expect to need a non-constant value for deleted fields or server timestamp-valued fields.

ArrayUnion and ArrayRemove will not be constants, but rather helper classes (see my comment in #6546).

We have no conformance tests for any numeric_add transform, and I do not see any corresponding element in the FieldTransform docs.

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 17, 2018
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Nov 19, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Nov 19, 2018
@crwilcox
Copy link
Contributor Author

Closing as #6546 is the work item. This will be fixed if necessary via that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tseaver @JustinBeckwith @crwilcox