Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support array_contains in queries #6479

Closed
RohanTalip opened this issue Nov 12, 2018 · 8 comments · Fixed by #6481
Closed

Please support array_contains in queries #6479

RohanTalip opened this issue Nov 12, 2018 · 8 comments · Fixed by #6481
Assignees
Labels
api: firestore Issues related to the Firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@RohanTalip
Copy link
Contributor

array_contains is supported in most other languages (Python and Ruby are holdouts) :
https://firebase.google.com/docs/firestore/query-data/queries#array_membership

Is there a timeframe for when this might become available for Python?

@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: firestore Issues related to the Firestore API. labels Nov 12, 2018
@RohanTalip
Copy link
Contributor Author

@tseaver, thanks! I'm assuming that you or someone else will create an internal bug or ticket to update https://firebase.google.com/docs/firestore/query-data/queries once this change is released?

@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2018

@RohanTalip I don't have access to the internal ticket system.

@crwilcox Can you bridge to the team that manages those snippets?

@RohanTalip
Copy link
Contributor Author

@tseaver and @crwilcox, roughly when do you think this change will be released?

I see that firestore-0.30.0 was released on 2018-10-15.

Are there other changes that need to be rolled up into firestore-0.31.0 ?

@tseaver
Copy link
Contributor

tseaver commented Nov 20, 2018

@RohanTalip There are a bunch of things pending. Maybe by the beginning of December we will be in a place to make a release.

@RohanTalip
Copy link
Contributor Author

@tseaver, OK, I'll monkey-patch this change until then.

@Emsu
Copy link

Emsu commented Dec 20, 2018

@tseaver I know you mentioned maybe at the beginning of December this would be released. Any updates?

@RohanTalip
Copy link
Contributor Author

@RohanTalip
Copy link
Contributor Author

FYI, I just sent some feedback on https://firebase.google.com/docs/firestore/query-data/queries#array_membership via the "SEND FEEDBACK" button, that this is now supported in Python. I linked to this issue in the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
3 participants