-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more useful header info on HTTP requests #3006
Comments
Seems like we could override the from pkg_resources import get_distribution
from google.cloud._http import JSONConnection
class Connection(JSONConnection):
USER_AGENT = 'google-cloud-foo-python/{0}'.format(
get_distribution('google-cloud-foo').version) I don't know whether the |
It is actually moving to a new header, We also intend to track the language via We probably still need to set a User-Agent string (just because it is considered good practice), and it does not matter what it is. |
@lukesneeringer The value of |
This is no longer true. The new header is superceding the old one. |
#3035 is most of the " |
Remaining APIs:
|
Most relevant place: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/9619004959def22ad2084691f382dc1cada46afd/core/google/cloud/_http.py#L177
May want to make this easier to use upstream
/cc @lukesneeringer
The text was updated successfully, but these errors were encountered: