Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Spanner): float 32 support #7080

Merged
merged 11 commits into from
Mar 28, 2024
Merged

feat(Spanner): float 32 support #7080

merged 11 commits into from
Mar 28, 2024

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Feb 21, 2024 •
edited
Loading

  1. Tested by changing keyFilePath and serviceAddress in SpannerTestCase and SpannerPgTestCase to staging env, span-cloud-testing
  2. All tests passing in local and on PROD, but some functionality don't seem to be available even on emulators.
  3. Feature is supposed to not be merged, until its available in PROD.

go/cloud-spanner-float32

# get key from https://valentine.corp.google.com/#/show/1710318067698488?tab=metadata
➜  Spanner git:(float32_spanner) ✗ export GOOGLE_CLOUD_PHP_TESTS_KEY_PATH=$HOME/github/automation/gcp_keys/span-cloud-staging.json 
➜  Spanner git:(float32_spanner) ✗ export SPANNER_SERVICE_ADDRESS=staging-wrenchworks.sandbox.googleapis.com                       
➜  Spanner git:(float32_spanner) ✗ vendor/bin/phpunit -c phpunit-system.xml.dist
Using Service Address: staging-wrenchworks.sandbox.googleapis.com
Using Service Address: staging-wrenchworks.sandbox.googleapis.com
PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

...............................................................  63 / 456 ( 13%)
............................................................... 126 / 456 ( 27%)
............................................................... 189 / 456 ( 41%)
............................................................... 252 / 456 ( 55%)
............................................................... 315 / 456 ( 69%)
............................................................... 378 / 456 ( 82%)
............................................................... 441 / 456 ( 96%)
...............                                                 456 / 456 (100%)

Time: 06:23.811, Memory: 54.00 MB

OK (456 tests, 1208 assertions)
➜  Spanner git:(float32_spanner) ✗

BREAKING_CHANGE_REASON="ValueMapper::allowedTypes has been marked @internal"

@vishwarajanand
feat(Spanner): float 32 support
8cd361c 
	modified:   src/Database.php
	modified:   src/ValueMapper.php
	modified:   tests/System/PgQueryTest.php
	modified:   tests/System/PgWriteTest.php
	modified:   tests/System/QueryTest.php
	modified:   tests/System/WriteTest.php
	modified:   tests/Unit/ValueMapperTest.php
@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 21, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Feb 21, 2024
arawind
arawind reviewed Mar 11, 2024
View reviewed changes
Copy link

@arawind arawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. The changes mostly LGTM. I've requested a few tests to be added.

Spanner/src/ValueMapper.php Show resolved Hide resolved
Spanner/tests/System/PgQueryTest.php Show resolved Hide resolved
Spanner/tests/System/QueryTest.php Show resolved Hide resolved
@vishwarajanand vishwarajanand marked this pull request as ready for review March 13, 2024 12:47
@vishwarajanand vishwarajanand requested review from a team as code owners March 13, 2024 12:47
ajupazhamayil
ajupazhamayil approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ajupazhamayil ajupazhamayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishwarajanand
Copy link
Contributor Author

The feature is merged into PROD, and tests are passing, so going ahead with the merge.

➜  Spanner git:(float32_spanner) ✗ vendor/bin/phpunit -c phpunit-system.xml.dist 
PHPUnit 9.6.18 by Sebastian Bergmann and contributors.

S..............................................................  63 / 457 ( 13%)
............................................................... 126 / 457 ( 27%)
............................................................... 189 / 457 ( 41%)
............................................................... 252 / 457 ( 55%)
............................................................... 315 / 457 ( 68%)
............................................................... 378 / 457 ( 82%)
............................................................... 441 / 457 ( 96%)
................                                                457 / 457 (100%)

Time: 02:07.050, Memory: 70.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 457, Assertions: 1248, Skipped: 1.
➜  Spanner git:(float32_spanner) ✗

@vishwarajanand vishwarajanand removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2024
@vishwarajanand vishwarajanand merged commit 8d3c0fd into googleapis:main Mar 28, 2024
23 checks passed
@release-please release-please bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arawind arawind arawind left review comments

@ajupazhamayil ajupazhamayil ajupazhamayil approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishwarajanand @arawind @ajupazhamayil