Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: [Firestore] remove types QueryMode, QueryPlan, ResultSetStats #7003

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 25, 2024

  • Regenerate this pull request now.

fix!: remove QueryMode field from RunQueryRequest
fix!: remove ResultSetStats field from RunQueryResponse
fix!: remove QueryMode field from RunAggregationQueryRequest
fix!: remove ResultSetStats field from RunAggregationQueryResponse

PiperOrigin-RevId: 601486523

Source-Link: googleapis/googleapis@a8b027a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b9b571f58541c0ace1ff94bf22af3d063eebfb7c
Copy-Tag: eyJwIjoiRmlyZXN0b3JlLy5Pd2xCb3QueWFtbCIsImgiOiJiOWI1NzFmNTg1NDFjMGFjZTFmZjk0YmYyMmFmM2QwNjNlZWJmYjdjIn0=

BREAKING_CHANGE_REASON=these changes were released 3 weeks ago, so we think that rolling these changes back without bumping a major version will be LESS work for our users than releasing a new major version

fix!: remove QueryMode field from RunQueryRequest
fix!: remove ResultSetStats field from RunQueryResponse
fix!: remove QueryMode field from RunAggregationQueryRequest
fix!: remove ResultSetStats field from RunAggregationQueryResponse

PiperOrigin-RevId: 601486523

Source-Link: googleapis/googleapis@a8b027a

Source-Link: googleapis/googleapis-gen@b9b571f
Copy-Tag: eyJwIjoiRmlyZXN0b3JlLy5Pd2xCb3QueWFtbCIsImgiOiJiOWI1NzFmNTg1NDFjMGFjZTFmZjk0YmYyMmFmM2QwNjNlZWJmYjdjIn0=
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 25, 2024 20:06
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 25, 2024 20:06
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@bshaffer bshaffer merged commit 40a852c into main Jan 26, 2024
28 of 29 checks passed
@bshaffer bshaffer deleted the owl-bot-copy-Firestore branch January 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant