Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OsLogin] added field ImportSshPublicKeyRequest.regions #6951

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 8, 2024

  • Regenerate this pull request now.

PiperOrigin-RevId: 596735856

Source-Link: googleapis/googleapis@87e7305

Source-Link: https://github.com/googleapis/googleapis-gen/commit/114ca4d376e84533150088df8ac86e098241e966
Copy-Tag: eyJwIjoiT3NMb2dpbi8uT3dsQm90LnlhbWwiLCJoIjoiMTE0Y2E0ZDM3NmU4NDUzMzE1MDA4OGRmOGFjODZlMDk4MjQxZTk2NiJ9

feat: add regions field to ImportSshPublicKeyRequest

PiperOrigin-RevId: 596667704

Source-Link: googleapis/googleapis@c340584

Source-Link: https://github.com/googleapis/googleapis-gen/commit/53aa884167571044501d074220e63abcd98c6ac1
Copy-Tag: eyJwIjoiT3NMb2dpbi8uT3dsQm90LnlhbWwiLCJoIjoiNTNhYTg4NDE2NzU3MTA0NDUwMWQwNzQyMjBlNjNhYmNkOThjNmFjMSJ9

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 8, 2024 23:06
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 8, 2024 23:06
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot changed the title feat: [OsLogin] add regions field to ImportSshPublicKeyRequest feat: [OsLogin] added field ImportSshPublicKeyRequest.regions Jan 9, 2024
Copy link

snippet-bot bot commented Jan 9, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be wired up correctly, but the ImportSshPublicKeyRequest class in V1beta is not updating as expected (it should receive the new regions field like the V1 version is). The same class in googleapis-gen is correct, and the owlbot copy config all looks good as well, so I'm not sure what's causing this issue.

https://github.com/googleapis/googleapis-gen/blob/master/google/cloud/oslogin/v1beta/google-cloud-oslogin-v1beta-php/proto/src/Google/Cloud/OsLogin/V1beta/ImportSshPublicKeyRequest.php

Copy link
Contributor Author

gcf-owl-bot bot commented Jan 12, 2024

Owl bot is regenerating pull request 6951...
Build name: MDM1YTUyNTAtMDdlNy00ZDU3LTljMDUtYTY5NDYyMjE2ZWE1

PiperOrigin-RevId: 596735856

Source-Link: googleapis/googleapis@87e7305

Source-Link: googleapis/googleapis-gen@114ca4d
Copy-Tag: eyJwIjoiT3NMb2dpbi8uT3dsQm90LnlhbWwiLCJoIjoiMTE0Y2E0ZDM3NmU4NDUzMzE1MDA4OGRmOGFjODZlMDk4MjQxZTk2NiJ9

feat: add regions field to ImportSshPublicKeyRequest

PiperOrigin-RevId: 596667704

Source-Link: googleapis/googleapis@c340584

Source-Link: googleapis/googleapis-gen@53aa884
Copy-Tag: eyJwIjoiT3NMb2dpbi8uT3dsQm90LnlhbWwiLCJoIjoiNTNhYTg4NDE2NzU3MTA0NDUwMWQwNzQyMjBlNjNhYmNkOThjNmFjMSJ9
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-OsLogin branch from c411f10 to 892f7d7 Compare January 12, 2024 02:34
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@bshaffer bshaffer enabled auto-merge (squash) January 12, 2024 13:37
@bshaffer bshaffer merged commit b7abd63 into main Jan 12, 2024
25 checks passed
@bshaffer bshaffer deleted the owl-bot-copy-OsLogin branch January 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant