Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define lowest deps correctly #6941

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: define lowest deps correctly #6941

merged 2 commits into from
Jan 5, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 5, 2024

The new check for installing lowest dependencies (#6899) found the following errors (yay!):

  • AlloyDB needs a minimum of google/common-protos:4.4
  • Channel needs a minimum ofgoogle/common-protos:3.2||4.0
  • Core needs to use more recent versions of guzzlehttp/psr and monolog/monolog
  • update root composer.json to match these changes

Additionally, I am adding the version field to google/longrunning, because otherwise it will constantly have issues with its circular dependency on google/gax.

@bshaffer bshaffer requested review from a team as code owners January 5, 2024 16:59
@bshaffer bshaffer enabled auto-merge (squash) January 5, 2024 17:03
@bshaffer bshaffer merged commit bcda6b2 into main Jan 5, 2024
25 checks passed
@bshaffer bshaffer deleted the chore-fix-deps branch January 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants