Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add PG.OID type support for parameterized queries #6788

Merged
merged 7 commits into from
May 27, 2024

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Nov 14, 2023

No description provided.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 14, 2023
@larkee larkee marked this pull request as ready for review November 14, 2023 09:58
@larkee larkee requested review from a team as code owners November 14, 2023 09:58
@larkee larkee force-pushed the spanner-pg-oid-support branch from 16c0332 to bfa208c Compare March 21, 2024 00:17
@larkee larkee force-pushed the spanner-pg-oid-support branch from bfa208c to 7b27b83 Compare March 26, 2024 01:35
@larkee
Copy link
Contributor Author

larkee commented Mar 26, 2024

I'm not sure how to address the backwards compatibility failure here.

@saranshdhingra
Copy link
Contributor

I'm not sure how to address the backwards compatibility failure here.

We have found another identical PR that has the same issue. We're discussing possible solutions. Possibly the allowedTypes should have been @internal from the start.

Let me respond here once we have finalized a fix.

@larkee
Copy link
Contributor Author

larkee commented Apr 8, 2024

@saranshdhingra Is there any update?

@saranshdhingra
Copy link
Contributor

Sorry for the delay @larkee
We had added the @internal annotation to the $allowedTypes variable.

PR LGTM.

@larkee larkee merged commit 273683d into googleapis:main May 27, 2024
22 checks passed
@larkee larkee deleted the spanner-pg-oid-support branch May 27, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants