-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev): add command to update composer deps #6773
Conversation
if [ $? != 0 ]; then | ||
echo "$DIR: composer install failed" >> "${FAILED_FILE}" | ||
# run again but without "-q" so we can see the error | ||
COMPOSER_ROOT_VERSION=$(cat $DIR/VERSION) composer --no-interaction --no-ansi --no-progress update -d ${DIR}; | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to this PR, but should this not be exit
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because we want to run all the tests even if one fails, so we can see if the others succeed or not. By sending the error in FAILED_FILE
, we ensure that we will exit below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, left a few nits
Co-authored-by: Vishwaraj Anand <[email protected]>
Command to set or bump composer deps.
This will be useful for implementing a GitHub Action to run the google/cloud package tests against new versions of GAX and Auth libraries before release.
TODO
consider using this command to replace logic done in: (this became overly complicated)google-cloud-php/.github/run-package-tests.sh
Lines 32 to 38 in 43b4687