feat(logging): add trace to logging on cloud run

[javihgil]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[javihgil]

Hi guys, I made this PR getting code from main branch, so I don't understand why Backwards compatibility check is failing.

What am I supposed to do to fix this?

Thanks

[yash30201]

Hi @javihgil , thanks a lot for taking time and contributing to the library.

Hi guys, I made this PR getting code from main branch, so I don't understand why Backwards compatibility check is failing.
What am I supposed to do to fix this?

It was caused due to some merge conflicts getting resolved in a way which deleted incoming changes. I've fixed it and now all the tests pass.

Can you please tell me your inspiration behind this PR? I would like to know what were you trying to do which led you to finding this feature absence and how doing this would help your work?

[javihgil]

Of course!

When you use this library with GAE, the Google\Cloud\Core\Report\GAEMetadataProvider sets an "appengine.googleapis.com/trace_id" label witch allows you to filter log entries by this trace, whose value is provided by HTTP_X_CLOUD_TRACE_CONTEXT header.

With CloudRun this header is also received, but it's ignored by CloudRunMetadataProvider so you can not filter log entries by trace_id.

This PR adds this label in metadata provider.

I renamed it to "run.googleapis.com/trace_id" instead of using "appengine.googleapis.com/trace_id" because I think is the propper way.

Thanks!

[yash30201]

Hi @javihgil , sorry for the long delay in this PR review.

So I've cross checked that we are getting the HTTP_X_CLOUD_TRACE_CONTEXT env variable set by the cloud run env. It's of the format specified here. Also, the naming of the label seems fine to me as it's inline with the cloud run's url . This PR seems fine to me with just one nit : )

@bshaffer , Can you please take look if everything looks okay from your side?
Ref: #1407 and b/312685152

[yash30201]

LGTM

[bshaffer]

Bump the google/cloud-core dependency to what will be the next release, as the tests depend on the new metadata provider class.

[bshaffer]

LGTM! Thank you for adding this.