fix!: [AnalyticsAdmin] delete BatchDeleteUserLinks, DeleteUserLink, BatchUpdateUserLinks, UpdateUserLink, BatchCreateUserLinks, CreateUserLink, AuditUserLinks, ListUserLinks, BatchGetUserLinks, GetUserLink from the Admin API v1 alph...
#6733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
…erLinks`, `UpdateUserLink`, `BatchCreateUserLinks`, `CreateUserLink`, `AuditUserLinks`, `ListUserLinks`, `BatchGetUserLinks`, `GetUserLink` from the Admin API v1 alpha as per the announcement in https://bit.ly/46yBIDt feat: add `UpdateDataRedactionSettings`, `CreateRollupProperty`, `GetRollupPropertySourceLink`, `ListRollupPropertySourceLinks`, `CreateRollupPropertySourceLink`, `DeleteRollupPropertySourceLink`, `CreateSubproperty`, `CreateSubpropertyEventFilter`, `CreateSubpropertyEventFilter`, `ListSubpropertyEventFilters`, `UpdateSubpropertyEventFilter`, `DeleteSubpropertyEventFilter` methods to the Admin API v1 alpha feat: add `include_all_users`, `expand_groups` fields to `RunAccessReportRequest` feat: add `DataRedactionSettings`, `RollupPropertySourceLink`, `SubpropertyEventFilterCondition`, `SubpropertyEventFilterExpression`, `SubpropertyEventFilterExpressionList`, `SubpropertyEventFilterClause`, `SubpropertyEventFilter` types feat: add the `DATA_REDACTION_SETTINGS` option to the `ChangeHistoryResourceType` enum feat: add the `data_redaction_settings` field to the `ChangeHistoryResource.resource` oneof field PiperOrigin-RevId: 574877732 Source-Link: googleapis/googleapis@a3006dd Source-Link: googleapis/googleapis-gen@4eb740a Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjRlYjc0MGE0Y2YyMWMxM2QxMzczN2IzNDg4ZmE0Yzc1MmUxM2I3OWQifQ==
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
|
Here is the summary of changes. You are about to add 10 region tags.
This comment is generated by snippet-bot.
|
gcf-owl-bot
bot
removed
the
owlbot:run
vishwarajanand
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
LGTM
Note:
BC Compat checker is complaining of some previously-public methods as being deleted in this PR. But seems this library isnt public yet, hence I added a BC check skip label and merging this PR.
See the below command gives a preview only for AnalyticsAdmin.
github/google-cloud-php % dev/google-cloud component-info --expanded | grep AnalyticsAdmin (git)-[main]-
| AnalyticsAdmin\V1beta | google/analytics-admin | 0.18.1 | V1beta | preview | v1 and v2 | google/analytics/admin/v1beta | analyticsadmin |
| AnalyticsAdmin\V1alpha | google/analytics-admin | 0.18.1 | V1alpha | preview | v1 | google/analytics/admin/v1alpha | analyticsadmin |
github/google-cloud-php %
@vishwarajanand an important correction... "Preview" does not mean it isn't public. It's very much public. But we can take breaking changes in "preview" because it's synonymous with "beta" or "experimental". We still don't WANT to take breaking changes, and we need to confirm the reason for the breaking changes. So a good policy is to check the Piper RevId, which will link to a bug for the breaking change. Then verify the reason for the breaking change and paste it here in the PR. So, a better |
yash30201
pushed a commit
to yash30201/google-cloud-php
that referenced
this pull request
Oct 27, 2023
…erLinks`, `UpdateUserLink`, `BatchCreateUserLinks`, `CreateUserLink`, `AuditUserLinks`, `ListUserLinks`, `BatchGetUserLinks`, `GetUserLink` from the Admin API v1 alph... (googleapis#6733) * fix!: delete `BatchDeleteUserLinks`, `DeleteUserLink`, `BatchUpdateUserLinks`, `UpdateUserLink`, `BatchCreateUserLinks`, `CreateUserLink`, `AuditUserLinks`, `ListUserLinks`, `BatchGetUserLinks`, `GetUserLink` from the Admin API v1 alpha as per the announcement in https://bit.ly/46yBIDt feat: add `UpdateDataRedactionSettings`, `CreateRollupProperty`, `GetRollupPropertySourceLink`, `ListRollupPropertySourceLinks`, `CreateRollupPropertySourceLink`, `DeleteRollupPropertySourceLink`, `CreateSubproperty`, `CreateSubpropertyEventFilter`, `CreateSubpropertyEventFilter`, `ListSubpropertyEventFilters`, `UpdateSubpropertyEventFilter`, `DeleteSubpropertyEventFilter` methods to the Admin API v1 alpha feat: add `include_all_users`, `expand_groups` fields to `RunAccessReportRequest` feat: add `DataRedactionSettings`, `RollupPropertySourceLink`, `SubpropertyEventFilterCondition`, `SubpropertyEventFilterExpression`, `SubpropertyEventFilterExpressionList`, `SubpropertyEventFilterClause`, `SubpropertyEventFilter` types feat: add the `DATA_REDACTION_SETTINGS` option to the `ChangeHistoryResourceType` enum feat: add the `data_redaction_settings` field to the `ChangeHistoryResource.resource` oneof field PiperOrigin-RevId: 574877732 Source-Link: googleapis/googleapis@a3006dd Source-Link: googleapis/googleapis-gen@4eb740a Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjRlYjc0MGE0Y2YyMWMxM2QxMzczN2IzNDg4ZmE0Yzc1MmUxM2I3OWQifQ==
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a as per the announcement in https://bit.ly/46yBIDt
feat: add
UpdateDataRedactionSettings,CreateRollupProperty,GetRollupPropertySourceLink,ListRollupPropertySourceLinks,CreateRollupPropertySourceLink,DeleteRollupPropertySourceLink,CreateSubproperty,CreateSubpropertyEventFilter,CreateSubpropertyEventFilter,ListSubpropertyEventFilters,UpdateSubpropertyEventFilter,DeleteSubpropertyEventFiltermethods to the Admin API v1 alphafeat: add
include_all_users,expand_groupsfields toRunAccessReportRequestfeat: add
DataRedactionSettings,RollupPropertySourceLink,SubpropertyEventFilterCondition,SubpropertyEventFilterExpression,SubpropertyEventFilterExpressionList,SubpropertyEventFilterClause,SubpropertyEventFiltertypesfeat: add the
DATA_REDACTION_SETTINGSoption to theChangeHistoryResourceTypeenumfeat: add the
data_redaction_settingsfield to theChangeHistoryResource.resourceoneof fieldPiperOrigin-RevId: 574877732
Source-Link: googleapis/googleapis@a3006dd
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4eb740a4cf21c13d13737b3488fa4c752e13b79d
Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6IjRlYjc0MGE0Y2YyMWMxM2QxMzczN2IzNDg4ZmE0Yzc1MmUxM2I3OWQifQ==
BREAKING_CHANGE_REASON=this API is not public yet