-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev): add release-info command #6363
Conversation
$application = new Application(); | ||
$application->add(new ComponentInfoCommand()); | ||
self::$commandTester = new CommandTester($application->get('component-info')); | ||
self::$commandTester = new CommandTester(new ComponentInfoCommand()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just cleaning up / simplifying these tests, as we can just create the CommandTester
directly when we don't need to test things like Question Helpers (e.g. $this->getHelper('question')
)
TLDR: it's cleanup that is unrelated to the release-info
command
$application = new Application(); | ||
$application->add(new DocFxCommand()); | ||
self::$commandTester = new CommandTester($application->get('docfx')); | ||
self::$commandTester = new CommandTester(new DocFxCommand()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit. LGTM
Command to display information about a released tag:
The
--format=json
option can be used to parse the output from another script: