Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce DiscoveryEngine #6212

Merged
merged 3 commits into from
May 12, 2023
Merged

feat: introduce DiscoveryEngine #6212

merged 3 commits into from
May 12, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented May 10, 2023 •
edited
Loading

b/280136004

The tests are failing due to googleapis/gapic-generator-php#628 The tests have been fixed!

@bshaffer bshaffer requested review from a team as code owners May 10, 2023 16:06
@snippet-bot
Copy link

snippet-bot bot commented May 10, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer mentioned this pull request May 10, 2023
Closed
@bshaffer bshaffer added the next release PRs to be included in the next release label May 11, 2023
@bshaffer bshaffer merged commit a301ea0 into main May 12, 2023
@bshaffer bshaffer deleted the introduce-discoveryengine branch May 12, 2023 14:45
@release-please release-please bot mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saranshdhingra saranshdhingra saranshdhingra approved these changes

Assignees
No one assigned
Labels
next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @saranshdhingra