Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Cloud Support #6140

Merged
merged 2 commits into from
May 5, 2023
Merged

feat: Introduce Cloud Support #6140

merged 2 commits into from
May 5, 2023

Conversation

yash30201
Copy link
Contributor

For more info, see b/280092087

PiperOrigin-RevId: 527954020

@yash30201 yash30201 requested review from a team as code owners April 29, 2023 05:43
@snippet-bot
Copy link

snippet-bot bot commented Apr 29, 2023

Here is the summary of changes.

You are about to add 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer
Copy link
Contributor

bshaffer commented May 1, 2023

@yash30201 I think we should try to release this library as a V2 client only

Edit: see cl/528873101

@bshaffer
Copy link
Contributor

bshaffer commented May 4, 2023

@yash30201 this is ready to be rebuilt using the latest version of googleapis-gen (e.g. PiperOrigin-RevId: 529400435 or later)

@yash30201
Copy link
Contributor Author

@bshaffer I regenerated this component according to the updated bazel [Build](https://github.com/googleapis/googleapis/blob/master/google/cloud/support/v2/BUILD.bazel) in the googleapis repo.

🤔 Then indentation of some doc blocs seems little different to me (For eg, this). We follow a different indentation in hand written client libraries.

@bshaffer
Copy link
Contributor

bshaffer commented May 5, 2023

@yash30201 that indentation looks correct to me. What indentation would you expect?

@bshaffer bshaffer merged commit f7f5cfb into main May 5, 2023
@bshaffer bshaffer deleted the gen-cloudsupport-v2 branch May 5, 2023 17:18
@bshaffer bshaffer changed the title feat: Introduce Support feat: Introduce Cloud Support May 5, 2023
@yash30201
Copy link
Contributor Author

yash30201 commented May 8, 2023

@yash30201 that indentation looks correct to me. What indentation would you expect?

For example here, we indent next line from the start of the data type, instead of from the end of variable name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants