Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link to Google\Cloud\Core\Iterator\ItemIterator in BigQuery docs #580

Closed
tswast opened this issue Jul 13, 2017 · 2 comments · Fixed by #582
Closed

Broken link to Google\Cloud\Core\Iterator\ItemIterator in BigQuery docs #580

tswast opened this issue Jul 13, 2017 · 2 comments · Fixed by #582
Assignees
@jdpedrie
Labels
documentation

Comments

@tswast
Copy link

tswast commented Jul 13, 2017

On the QueryResults.rows() function docs, it links to the return type Google\Cloud\Core\Iterator\ItemIterator at https://googleapis.github.io/gax-php/0.21.0/Google/Cloud/Core/Iterator/ItemIterator.html but this link 404s.
@dwsupplee
Copy link
Contributor

Thanks for the report @tswast, taking a look now.

@michaelbausor michaelbausor mentioned this issue Jul 13, 2017
Closed
@dwsupplee dwsupplee mentioned this issue Jul 13, 2017
Merged
@dwsupplee dwsupplee reopened this Jul 13, 2017
@dwsupplee
Copy link
Contributor

We need to regenerate the docs for versions 0.33.0+, I will leave this open until that is complete using the work implemented in #582.

@dwsupplee dwsupplee mentioned this issue Jul 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdpedrie jdpedrie

Labels
documentation
Projects
None yet
Milestone
No milestone
3 participants
@jdpedrie @tswast @dwsupplee