feat(ErrorReporting): Generate HttpRequestContext for log context. #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: clouderrorreporting
westy92
force-pushed
the
add-http-request-info
branch
from
5c96744 to
dd02ae2
Compare
bshaffer
approved these changes
Jul 31, 2023
Comment on lines
183
to
186
| } finally { | ||
| // restore | ||
| $_SERVER = $oldServer; | ||
| } |
There was a problem hiding this comment.
A way to get around doing this type of thing is to just add @runInSeparateProcess for PHPUnit, and then modifying the $_SERVER will only affect this test
|
@westy92 thank you for this amazing contribution! |
|
You're welcome, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code to generate
context.httpRequestas mentioned in the docs.